api icon indicating copy to clipboard operation
api copied to clipboard

API-1689: features: add ShortCertRotation

Open vrutkovs opened this issue 1 year ago • 8 comments

Enhancement proposal: https://github.com/openshift/enhancements/pull/1670

vrutkovs avatar Jul 30 '24 11:07 vrutkovs

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 30 '24 11:07 openshift-ci[bot]

Hello @vrutkovs! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jul 30 '24 11:07 openshift-ci[bot]

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 26 '24 09:08 openshift-ci-robot

/retest

vrutkovs avatar Aug 26 '24 13:08 vrutkovs

/test e2e-aws-ovn

vrutkovs avatar Aug 26 '24 15:08 vrutkovs

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to this:

Enhancement proposal: https://github.com/openshift/enhancements/pull/1670

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 28 '24 14:08 openshift-ci-robot

/lgtm

JoelSpeed avatar Mar 10 '25 15:03 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 10 '25 15:03 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD b8da3bfeaf773d9dce2ea56edc9a1cf06cfdbd80 and 2 for PR HEAD b8d74abdb5a80cb2b5aa798ad988c20226edcc02 in total

openshift-ci-robot avatar Mar 10 '25 19:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD b8da3bfeaf773d9dce2ea56edc9a1cf06cfdbd80 and 2 for PR HEAD b8d74abdb5a80cb2b5aa798ad988c20226edcc02 in total

openshift-ci-robot avatar Mar 11 '25 04:03 openshift-ci-robot

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 11 '25 08:03 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.19.0-202503111040.p0.g14a17c7.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Mar 11 '25 11:03 openshift-bot