api
api copied to clipboard
openshift
Run update-payload-crds after update-codegen-crds
When working on #1928, noticed that the payload crds were not generated after running a make update. This is because codegen is run after update-scripts. This PR removes update-payload-crds from update-scripts and runs it after codegen.
Hello @Prashanth684! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, Prashanth684
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 0d46442e8df17a87cfcf6666ab19b28e88620b59 and 2 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total
/retest-required
Remaining retests: 0 against base HEAD e863d9f8a215ce75d09033a69d180922d00a52b9 and 1 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total
/retest-required
Remaining retests: 0 against base HEAD c299a673ec729b7e63a6c363d67e961454218e09 and 0 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total
/hold
Revision d90bbeacb625b238c389284499f74c833014935c was retested 3 times: holding
@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp | d90bbeacb625b238c389284499f74c833014935c | link | false | /test e2e-gcp |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/hold cancel /override ci/prow/e2e-aws-ovn
This PR doesn't affect the E2Es
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn
In response to this:
/hold cancel /override ci/prow/e2e-aws-ovn
This PR doesn't affect the E2Es
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 8b2b377d9d42634867e281b57218c372fe432cbe and 2 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408030144.p0.g7461358.assembly.stream.el9. All builds following this will include this PR.
