api
api copied to clipboard
openshift
MCO-1064: Disable tech preview
@dkhater-redhat: This pull request references MCO-1064 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Disabled tech preview for MachineConfigNodes FG
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @dkhater-redhat! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dkhater-redhat Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
Not clear to me what we are actually trying to achieve here. This is demoting the feature, I expect you actually want to promote the feature. Looking at the related epic, there are still a number of tasks to complete, so this feature is not yet ready to promote anyway.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp | 2ae6d1991a98c951583a87e88a578c784d0876a0 | link | false | /test e2e-gcp |
| ci/prow/verify | 2ae6d1991a98c951583a87e88a578c784d0876a0 | link | true | /test verify |
| ci/prow/e2e-aws-ovn-hypershift | 2ae6d1991a98c951583a87e88a578c784d0876a0 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/integration | 2ae6d1991a98c951583a87e88a578c784d0876a0 | link | true | /test integration |
| ci/prow/minor-e2e-upgrade-minor | 374e89ed6b0404c3ef1e325505e115ec1620f39f | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/minor-images | 374e89ed6b0404c3ef1e325505e115ec1620f39f | link | true | /test minor-images |
| ci/prow/lint | 374e89ed6b0404c3ef1e325505e115ec1620f39f | link | true | /test lint |
| ci/prow/verify-feature-promotion | 374e89ed6b0404c3ef1e325505e115ec1620f39f | link | true | /test verify-feature-promotion |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.