Deprecate unused MAPO fields

[stephenfin]

This has no impact on end-users, but is useful flag for us as we start translating from MAPO<->CAPO.

WIP as we compile our list of unused files through introspection of MAPO.

Signed-off-by: Stephen Finucane [email protected]

[openshift-ci[bot]]

Hello @stephenfin! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[stephenfin]

/cc @mdbooth

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[stephenfin]

/remove-lifecycle stale

[stephenfin]

I think this is ready for review now. To be clear, we do not need this but per comment 0 I do think it's useful signal for reviewers of the MAPO<->CAPO work and would like to see it merged if possible.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3689 which is a valid jira issue.

In response to this:

This has no real impact on end-users but it is useful flag for reviewers as we start translating from MAPO<->CAPO. Some of these issues - such as SecurityGroupFilter.TenantID being ignored rather than "coalesced" with the ProjectID field - are likely bugs, but we're not going to fix these at this stage of MAPO's lifecycle.

This was generated via manual inspection of MAPO, most significantly the https://github.com/openshift/machine-api-provider-openstack/blob/release-4.18/pkg/machine/convert.go file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

OpenAPI generation needs to be updated, but otherwise LGTM

[openshift-ci[bot]]

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mdbooth]

/lgtm

[JoelSpeed]

/lgtm /label acknowledge-critical-fixes-only

Docs only change

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mdbooth, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.19.0-202501201238.p0.g366ffb8.assembly.stream.el9. All builds following this will include this PR.