api icon indicating copy to clipboard operation
api copied to clipboard

OCPNODE-2388: add UserNamespacesSupport to TechPreview feature gates

Open haircommander opened this issue 1 year ago • 5 comments

haircommander avatar Jun 28 '24 20:06 haircommander

@haircommander: This pull request references OCPNODE-2388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 28 '24 20:06 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jun 28 '24 20:06 openshift-ci[bot]

Hello @haircommander! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jun 28 '24 20:06 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 28 '24 20:06 openshift-ci[bot]

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-hypershift 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-upgrade
ci/prow/e2e-upgrade-minor 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn 86cb0ebae00045eea10cff9bbe80636761857b61 link true /test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor e66beab50b38ea3ad362a1638f28dc5eeaf499b8 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images e66beab50b38ea3ad362a1638f28dc5eeaf499b8 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 14:08 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

I think we should just carry this in https://github.com/openshift/api/pull/1939

haircommander avatar Aug 19 '24 19:08 haircommander