api icon indicating copy to clipboard operation
api copied to clipboard

WIP: Remove imagecontentpolicy CRD

Open QiWang19 opened this issue 1 year ago • 10 comments

https://redhat-internal.slack.com/archives/CE4L0F143/p1712754654588479?thread_ts=1712686968.703299&cid=CE4L0F143

QiWang19 avatar Jun 25 '24 19:06 QiWang19

Hello @QiWang19! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jun 25 '24 19:06 openshift-ci[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jun 25 '24 19:06 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19 Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 25 '24 19:06 openshift-ci[bot]

/retest

QiWang19 avatar Aug 05 '24 20:08 QiWang19

/test verify

QiWang19 avatar Aug 06 '24 19:08 QiWang19

/retest-required

QiWang19 avatar Aug 07 '24 15:08 QiWang19

/retest-required

QiWang19 avatar Aug 07 '24 16:08 QiWang19

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 15 '24 14:08 openshift-merge-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Nov 14 '24 01:11 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 04 '25 00:01 openshift-bot

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 865093f92719aeb60f691400844b8df75380487b link false /test e2e-gcp
ci/prow/e2e-azure 865093f92719aeb60f691400844b8df75380487b link false /test e2e-azure
ci/prow/verify 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test verify
ci/prow/verify-crd-schema 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test verify-crd-schema
ci/prow/e2e-aws-ovn 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test minor-images
ci/prow/lint 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test lint
ci/prow/verify-feature-promotion 8336ee9eff8b49fe5d33193fca9ef6e24b91b0e9 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 28 '25 09:01 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Feb 28 '25 00:02 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Feb 28 '25 00:02 openshift-ci[bot]