api
api copied to clipboard
openshift
MON-3902: add initial Monitoring CRD api
Initial Implementation of Configuration CRD for the Cluster Monitoring Operator
Related: [link]
As we have a FeatureGate, the idea is to implement component by component to verify the correct behavior and facilitate the reviews.
The API comes from https://github.com/openshift/cluster-monitoring-operator/blob/7015893ece5ed0a6f888fffe09b6d10a807d6901/pkg/manifests/config.go#L51
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @marioferh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@marioferh: This pull request references MON-3902 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.
In response to this:
Initial Implementation of Configuration CRD for the Cluster Monitoring Operator
Related: [link]
As we have a FeatureGate, the idea is to implement component by component to verify the correct behavior and facilitate the reviews.
The API comes from https://github.com/openshift/cluster-monitoring-operator/blob/7015893ece5ed0a6f888fffe09b6d10a807d6901/pkg/manifests/config.go#L51
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/lgtm
only verify is now unhappy. Guess needs some generate step again or so?
/lgtm only
verifyis now unhappy. Guess needs some generate step again or so?
something related with CustomNoUpgrade:
Found untracked file 0000_10_config-operator_01_clustermonitoring-CustomNoUpgrade.crd.yaml in payload CRD manifests. Please add the file to crd_globs in hack/update-payload-crds.sh.
make: *** [Makefile:52: verify-scripts] Error 1
@marioferh: This pull request references MON-3902 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.
In response to this:
Initial Implementation of Configuration CRD for the Cluster Monitoring Operator
Related: Enhancements Proposal [link]
As we have a FeatureGate, the idea is to implement component by component to verify the correct behavior and facilitate the reviews.
The API comes from https://github.com/openshift/cluster-monitoring-operator/blob/7015893ece5ed0a6f888fffe09b6d10a807d6901/pkg/manifests/config.go#L51
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
From the linter, these ones should be fixed. The first four WRT empty json tag is a bug that I'll fix this afternoon
config/v1/types_cluster_monitoring.go:63:2: optionalorrequired: field Items must be marked as optional or required (kal)
Items []ClusterMonitoring `json:"items"`
^
config/v1/types_cluster_monitoring.go:[45](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1929/pull-ci-openshift-api-master-lint/1868744969225768960#1:build-log.txt%3A45):2: requiredfields: field Spec is marked as required, but has the omitempty tag (kal)
Spec ClusterMonitoringSpec `json:"spec,omitempty"`
^
config/v1/types_cluster_monitoring.go:70:2: requiredfields: field UserDefined is marked as required, but has the omitempty tag (kal)
UserDefined UserDefinedMonitoring `json:"userDefined,omitempty"`
^
config/v1/types_cluster_monitoring.go:81:2: requiredfields: field Mode is marked as required, but has the omitempty tag (kal)
Mode UserDefinedMode `json:"mode,omitempty"`
^
Changes LGTM, waiting on a linter fix to merge to verify a green lint, and then we can get this merged
In the mean time, will double check on EP updates
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jan--f, JoelSpeed, marioferh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment