api
api copied to clipboard
openshift
MULTIARCH-4556: Introduce ImageStreamImportMode field in the image config
This is the api implementation for https://github.com/openshift/enhancements/pull/1605
- Introduces ImageStreamImportMode field in the image config spec and status - the status will be consumed by apiserver to set importMode for all imagestreams
- Introduce an
ImageStreamImportModetech preview feature gate - Add feature gate test
@Prashanth684: This pull request references MULTIARCH-4556 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
This is the api implementation for https://github.com/openshift/enhancements/pull/1605
- Introduces ImageStreamImportMode field in the image config spec and status - the status will be consumed by apiserver to set importMode for all imagestreams
- Introduce an
ImageStreamImportModetech preview feature gate- Add feature gate test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @Prashanth684! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
verify and verify-crd-schema are failing as these are changes to a crd which has not been touched in a while.
There appears to be a yaml error in the integration tests you've added, check the failures
could not load schema check generation contexts from dir "/go/src/github.com/openshift/api/image/v1/tests": could not unmarshal YAML for type meta inspection: error converting YAML to JSON: yaml: line 7: mapping values are not allowed in this context
Still something wrong in the test files, from verify-crd-schema
Please can you resolve the following
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.externalRegistryHostnames must set x-kubernetes-list-type
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.allowedRegistries must set x-kubernetes-list-type
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.blockedRegistries must set x-kubernetes-list-type
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.insecureRegistries must set x-kubernetes-list-type
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.allowedRegistriesForImport must set x-kubernetes-list-type
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.status.externalRegistryHostnames must set x-kubernetes-list-type
SSA tags should be fixed as they come up
could not load schema check generation contexts from dir "/go/src/github.com/openshift/api/image/v1/tests": could not unmarshal YAML for type meta inspection: error converting YAML to JSON: yaml: line 7: mapping values are not allowed in this context
Still something wrong in the test files, from verify-crd-schema
ah..thanks for the catch..there was an indentation error in the ungated file. fixed it. The verify-crd-schema still fails, but think it is expected.
Please can you resolve the following
error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.externalRegistryHostnames must set x-kubernetes-list-type error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.allowedRegistries must set x-kubernetes-list-type error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.blockedRegistries must set x-kubernetes-list-type error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.registrySources.insecureRegistries must set x-kubernetes-list-type error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.spec.allowedRegistriesForImport must set x-kubernetes-list-type error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_images-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/images.config.openshift.io version/v1 field/^.status.externalRegistryHostnames must set x-kubernetes-list-typeSSA tags should be fixed as they come up
These are already existing fields in an already existing CRD. is the change simply to add // +listType=atomic ? Hopefully it won't impact the existing crd?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, Prashanth684
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
/lgtm /override ci/prow/verify-crd-schema
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD e48b223033d1c5c23d271a5fe9df9ac50f77db96 and 2 for PR HEAD fa3fbfeed8352aa03dd3d0b8f6c94eef2296726c in total
/override ci/prow/e2e-upgrade-minor
The minor upgrade has been broken since branching, I'm working on fixing it. Looking at the changes here the only upgrade potential issue would be the new SSA tags, but they are all atomic which is the default anyway, so there's no actual functional change
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade-minor
In response to this:
/override ci/prow/e2e-upgrade-minor
The minor upgrade has been broken since branching, I'm working on fixing it. Looking at the changes here the only upgrade potential issue would be the new SSA tags, but they are all atomic which is the default anyway, so there's no actual functional change
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Prashanth684: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.