api
api copied to clipboard
openshift
[release-4.14] CFE-1047: Added new field for capacityReservationGroupID in AzureMachineProviderSpec
Manual back-port for https://github.com/openshift/api/pull/1866
Hello @anirudhAgniRedhat! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anirudhAgniRedhat: This pull request references CFE-1047 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
Manual back-port for https://github.com/openshift/api/pull/1866
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@anirudhAgniRedhat: This pull request references CFE-1047 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
Manual back-port for https://github.com/openshift/api/pull/1866
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hey @JoelSpeed Can I get the approval for these as Scott has give approval for further Back-port https://redhat-internal.slack.com/archives/CBZHF4DHC/p1721939852676219?thread_ts=1712582367.529309&cid=CBZHF4DHC
@JoelSpeed As 4.15 back-port is completed can we start back-port for 4.14?
@anirudhAgniRedhat Yes I think so, are the other PRs ready to go? Do you think if we merge this now we will be able to get all PRs into a single weekly z?
Yeah!! @JoelSpeed All remaning PRs are up and QE verified except the CPMS bump one, I am planning to raise it as soon as API merges.
Anyways We cannot merge this until @sdodson is back from PTO which is monday, I need valid-bug tagfrom him.
/lgtm /label backport-risk-assessed
Ack, you can have my tags, pending scott to add the final one for merge
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anirudhAgniRedhat, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xingxingxia, @gangwgr , @wangke19 Can anyone of you would help me with the required tag?
@anirudhAgniRedhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.