api icon indicating copy to clipboard operation
api copied to clipboard

OCPNODE-2357: machineconfiguration: make crun as the default container runtime

Open sohankunkerkar opened this issue 1 year ago • 7 comments

Related to https://issues.redhat.com/browse/OCPNODE-2217

This commit sets crun as the default container runtime in OCP for 4.17

sohankunkerkar avatar Jun 10 '24 18:06 sohankunkerkar

Hello @sohankunkerkar! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jun 10 '24 18:06 openshift-ci[bot]

@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/OCPNODE-2217

This commit sets crun as the default container runtime in OCP for 4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 10 '24 19:06 openshift-ci-robot

/jira refresh

sohankunkerkar avatar Jun 10 '24 19:06 sohankunkerkar

@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 10 '24 19:06 openshift-ci-robot

/lgtm

rphillips avatar Jun 10 '24 20:06 rphillips

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips, sohankunkerkar, yuqi-zhang Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 29 '24 00:06 openshift-ci[bot]

@sohankunkerkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-minor 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-aws-ovn
ci/prow/e2e-upgrade 4248c111c3f8436322de1a9d315153ec8cfb053a link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 16:07 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Nov 14 '24 09:11 openshift-bot