api
api copied to clipboard
openshift
OCPBUGS-35051: Bump runlevel for ConsolePlugin CRD
It looks like the ConsolePlugin v1 api object is not created in time for the console-operator, since after the 4.11 -> 4.12 update console-operator is reporting:
...
2024-06-04T09:52:52.887020412Z W0604 09:52:52.886992 1 reflector.go:424] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io)
2024-06-04T09:52:52.887020412Z E0604 09:52:52.887011 1 reflector.go:140] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: Failed to watch *v1.ConsolePlugin: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io)
2024-06-04T09:53:30.853354736Z I0604 09:53:30.853322 1 shared_informer.go:281] stop requested
2024-06-04T09:53:30.853354736Z F0604 09:53:30.853338 1 base_controller.go:96] unable to sync caches for ConsoleOperator
/assign @wking
@jhadvig: This pull request references Jira Issue OCPBUGS-35051, which is invalid:
- expected the bug to target the "4.12.z" version, but no target version was set
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
- expected Jira Issue OCPBUGS-35051 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
It looks like the ConsolePlugin v1 api object is not created in time for the console-operator, since after the 4.11 -> 4.12 update console-operator is reporting:
... 2024-06-04T09:52:52.887020412Z W0604 09:52:52.886992 1 reflector.go:424] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io) 2024-06-04T09:52:52.887020412Z E0604 09:52:52.887011 1 reflector.go:140] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: Failed to watch *v1.ConsolePlugin: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io) 2024-06-04T09:53:30.853354736Z I0604 09:53:30.853322 1 shared_informer.go:281] stop requested 2024-06-04T09:53:30.853354736Z F0604 09:53:30.853338 1 base_controller.go:96] unable to sync caches for ConsoleOperator/assign @wking
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @jhadvig! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jhadvig Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Run level is part of an annotation on the API type, and then the file names are generated from there. Please review the Go type itself and you should see the // + marker to update
@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/integration | fe0b98c32ec5450822708251e4507809045e9026 | link | true | /test integration |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
No, more like the annotation on https://github.com/openshift/api/blob/a837bee24500e12cf6b5608620a36983d96b1e36/operator/v1/types_serviceca.go#L14
There's a CVO run level I think is the one you want to change
Right, unfortunatelly I dont see these in release-4.12 branch, which the PR aims against. Shall I add it ?
I did not notice this is for 4.12, is this updating the files to match what's present in master now?
Not necessarily, the issue is that API is not present on the 4.12 cluster after upgrade from 4.11.
Not necessarily, the issue is that API is not present on the 4.12 cluster after upgrade from 4.11.
I suspect you are going to need to adjust the run level in master, to make sure it's installed prior to your operator being upgraded, and then backport from there.
But there's also the ordering within the run level, I'd have thought you could change that to make sure the CRD is installed in 4.12 prior to your operator being upgraded and breaking
I see that the consoleplugin go type has runlvl 90 and other console manifest are at 00, is that correct ?
The rest of your manifests are at run level 90 in the operator repo itself, https://github.com/openshift/console-operator/tree/master/manifests
I think you need to add the run level, not the operator ordering, so it becomes run level 90 and operator order 01
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jhadvig: This pull request references Jira Issue OCPBUGS-35051. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
In response to this:
It looks like the ConsolePlugin v1 api object is not created in time for the console-operator, since after the 4.11 -> 4.12 update console-operator is reporting:
... 2024-06-04T09:52:52.887020412Z W0604 09:52:52.886992 1 reflector.go:424] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io) 2024-06-04T09:52:52.887020412Z E0604 09:52:52.887011 1 reflector.go:140] github.com/openshift/client-go/console/informers/externalversions/factory.go:101: Failed to watch *v1.ConsolePlugin: failed to list *v1.ConsolePlugin: the server could not find the requested resource (get consoleplugins.console.openshift.io) 2024-06-04T09:53:30.853354736Z I0604 09:53:30.853322 1 shared_informer.go:281] stop requested 2024-06-04T09:53:30.853354736Z F0604 09:53:30.853338 1 base_controller.go:96] unable to sync caches for ConsoleOperator/assign @wking
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.