addon-operator icon indicating copy to clipboard operation
addon-operator copied to clipboard

chore: parameterize status reporting environment variable

Open ashishmax31 opened this issue 1 year ago • 6 comments

What type of PR is this?

Add status reporting enable parameter to the template referenced by app-interface saas file

What this PR does / why we need it?

Conditionally enable status reporting in different ocm environments.

Which Jira/Github issue(s) this PR fixes?

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster
  • [ ] Ran make go-test command locally to run all the unit tests and mock tests locally.
  • [ ] Included documentation changes with PR

ashishmax31 avatar Jul 31 '24 08:07 ashishmax31

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashishmax31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 31 '24 08:07 openshift-ci[bot]

/test operator-e2e

ashishmax31 avatar Jul 31 '24 09:07 ashishmax31

/retest

ashishmax31 avatar Jul 31 '24 10:07 ashishmax31

/retest

ashishmax31 avatar Jul 31 '24 11:07 ashishmax31

@ashishmax31: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e 9a1371202fa90f5f500f76ce0a26d3905d23a3bd link true /test operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 31 '24 11:07 openshift-ci[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.01%. Comparing base (cb114d2) to head (9a13712). Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #625       +/-   ##
===========================================
- Coverage   72.53%   60.01%   -12.53%     
===========================================
  Files          51       62       +11     
  Lines        3350     4049      +699     
===========================================
  Hits         2430     2430               
- Misses        773     1472      +699     
  Partials      147      147               

see 11 files with indirect coverage changes

codecov-commenter avatar Jul 31 '24 15:07 codecov-commenter

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Oct 30 '24 01:10 openshift-bot