rewrite-migrate-java icon indicating copy to clipboard operation
rewrite-migrate-java copied to clipboard

Composite component facet name not replaced in Jakarta EE10 migration

Open jepsar opened this issue 7 months ago • 2 comments
trafficstars

I ran

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
    -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE \
    -Drewrite.activeRecipes=org.openrewrite.java.migrate.jakarta.JakartaEE10

and found that the composite component facet name was not replaced.

    container.getFacet("javax.faces.component.COMPOSITE_FACET_NAME")

Maybe this is too much of an edge case. Wanted to report it anyway.

CC @melloware

jepsar avatar Mar 25 '25 11:03 jepsar

Maybe related; in a custom validator we are getting messages by key:

    final String key = minimum
                               ? "javax.faces.validator.DoubleRangeValidator.MINIMUM"
                               : "javax.faces.validator.DoubleRangeValidator.MAXIMUM";

jepsar avatar Mar 25 '25 12:03 jepsar

PR submitted.

melloware avatar Mar 25 '25 12:03 melloware