lua-resty-redis icon indicating copy to clipboard operation
lua-resty-redis copied to clipboard

fix: include server_name in the connection pool

Open Tieske opened this issue 5 years ago • 3 comments
trafficstars

Tieske avatar Jan 30 '20 16:01 Tieske

@Tieske Hi, I think we have the arg pool, and we can set the pool as [<server_name>:]<host>:<port> outside the lib. Could you describe a situation we need this special arg?

rainingmaster avatar May 30 '20 03:05 rainingmaster

the default might reuse a connection opened with different properties, and hence is a security issue

Tieske avatar Jun 24 '20 11:06 Tieske

probably this isn't even enough, see https://github.com/ledgetech/lua-resty-http/pull/206/files#diff-654e4e7b65177f9d0e6eb1d4b1c259dbR133-R143

Tieske avatar Jun 24 '20 11:06 Tieske