lua-nginx-module
lua-nginx-module copied to clipboard
openresty
feature: Add FFI functions for ngx.req.get_post_args
I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.
Tests using the lua-resty-core implementation will fail due to the typo fixed up in https://github.com/openresty/lua-nginx-module/pull/990 (travis CI should pass here though); I'll rebase once that's merged.
@agentzh what are you thoughts on this PR? It would be nice to have this (lua-resty-core sister PR at https://github.com/openresty/lua-resty-core/pull/87) in :)
Thanks, updated to remove the post args constants, and moved the extra verification.
Will clean up the git history here when ready for merge, or we need more changes.
@p0pr0ck5 Don't worry about the git history too much. I'll always squash before merging manually. Basically it is recommended to use incremental commits for PR submitters in their own branch. Generally speaking, squashing by the PR authors themselves will make my life harder instead of easier. The only requirement on PR authors from my side is to ensure the branch can be rebased to the latest master cleanly, but it does not require the PR authors to actually rebase to the latest master periodically themselves (unless conflicts occur, of course). Sorry for the confusions!
@p0pr0ck5 Sorry for the delay on my side. This is still in my review queue. Will have another close look as soon as I can manage. Thanks!
@p0pr0ck5 Sorry, too busy with other higher priority stuff. Will look into this when I have a chance. Thanks for your understanding and sorry for the delay on my side.
@agentzh any thoughts on this? I've gotten some conflicting feedback here, would love to be able to clean it up and see this functionality merged :)
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}