lua-nginx-module icon indicating copy to clipboard operation
lua-nginx-module copied to clipboard

Published 20 hours ago • verified publisher icon openresty

feature: Added ngx_http_lua_ffi_ssl_ocsp_get_nextupdate

Open alubbe opened this issue 8 years ago • 4 comments

This PR is a possible solution to https://github.com/openresty/lua-resty-core/issues/75 and is complemented by https://github.com/openresty/lua-resty-core/pull/99. Looking forward to your feedback.

I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.

alubbe avatar Apr 14 '17 08:04 alubbe

Also, two newbie questions:

  1. I copied ngx_ssl_stapling_time over from the nginx source code because I couldn't figure out how to reference/reuse/import it. Is there a way to do this without patching nginx?
  2. Should ngx_http_lua_ffi_ssl_ocsp_get_nextupdate be in a header file somewhere?

alubbe avatar Apr 14 '17 08:04 alubbe

@alubbe To answer your questions:

  1. Static C functions cannot be reused outside that compilation unit.
  2. No. Those C functions are not meant to be used by other C code.

agentzh avatar Apr 14 '17 21:04 agentzh

@ghedo @lziest Do you mind reviewing this PR for me? Many thanks!

agentzh avatar Apr 14 '17 21:04 agentzh

Static C functions cannot be reused outside that compilation unit.

Fair enough. I will copy the contents and rename it to ngx_http_lua_ssl_stapling_time.

No. Those C functions are not meant to be used by other C code.

Can we also remove https://github.com/openresty/lua-nginx-module/pull/782/files#diff-c4f8697714ffd4ae8e3d403bc9a55715R17 ?

alubbe avatar Apr 16 '17 10:04 alubbe