html5pivotviewer icon indicating copy to clipboard operation
html5pivotviewer copied to clipboard

Selection Handling

Open ghost opened this issue 10 years ago • 1 comments

The selection handling code in both gridview.js and graphview.js includes a lot of variables not explicitly declared with "var." While this doesn't seem to cause problems at the moment, this is probably something that should be fixed.

ghost avatar Jan 21 '15 09:01 ghost

Also, both files make use of the line

if (selectedItem != null && selectedTile != null) {

It's within that scope that many of the aforementioned variables are first used and set. Given that the code following that scope makes use of those values, the code as it now stands is banking on the fact that that if statement will never be false.

ghost avatar Jan 21 '15 09:01 ghost