joss-reviews icon indicating copy to clipboard operation
joss-reviews copied to clipboard

[PRE REVIEW]: concore for Simulating Closed-Loop Peripheral Neuromodulation Control Systems

Open editorialbot opened this issue 3 years ago • 17 comments

Submitting author: @pradeeban (Pradeeban Kathiravelu) Repository: https://github.com/ControlCore-Project/concore/ Branch with paper.md (empty if default branch): Version: 2.0.1 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/33db304ac54c24ce0897de76beb7de62"><img src="https://joss.theoj.org/papers/33db304ac54c24ce0897de76beb7de62/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/33db304ac54c24ce0897de76beb7de62/status.svg)](https://joss.theoj.org/papers/33db304ac54c24ce0897de76beb7de62)

Author instructions

Thanks for submitting your paper to JOSS @pradeeban. Currently, there isn't a JOSS editor assigned to your paper.

@pradeeban if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot avatar Aug 11 '22 13:08 editorialbot

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot avatar Aug 11 '22 13:08 editorialbot

Software report:

github.com/AlDanial/cloc v 1.88  T=2.52 s (402.7 files/s, 148001.4 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
SWIG                                 3          66734            763         103365
C/C++ Header                       261          12751          16085          51555
C++                                 97           6812           6188          32858
MATLAB                             497           1910          32160          22032
XML                                 57              0             22          11136
Verilog-SystemVerilog               20            276            583           3070
Python                              42            428            403           2455
CMake                               14             98            110            442
Bourne Shell                         9             15             47            235
Markdown                             4             82              0            175
Bourne Again Shell                   4              1              0            113
TeX                                  1              0              0             40
DOS Batch                            4              3              0             23
YAML                                 1              1              4             18
MUMPS                                1              0              0              3
-----------------------------------------------------------------------------------
SUM:                              1015          89111          56365         227520
-----------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

editorialbot avatar Aug 11 '22 13:08 editorialbot

Wordcount for paper.md is 1007

editorialbot avatar Aug 11 '22 13:08 editorialbot

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/access.2022.3161471 may be a valid DOI for title: CONTROL-CORE: A Framework for Simulation and Design of Closed-Loop Peripheral Neuromodulation Control Systems
- 10.1109/tbme.2017.2759667 may be a valid DOI for title: Closed-loop vagus nerve stimulation based on state transition models
- 10.1145/3154979.3154984 may be a valid DOI for title: Generation and proliferation of random directed acyclic graphs for workflow scheduling problem

INVALID DOIs

- None

editorialbot avatar Aug 11 '22 13:08 editorialbot

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Aug 11 '22 13:08 editorialbot

Thanks, @editorialbot. The suggested DOIs are correct. I have added the DOIs to the paper now and committed to GitHub.

pradeeban avatar Aug 11 '22 14:08 pradeeban

@editorialbot commands

pradeeban avatar Aug 11 '22 14:08 pradeeban

Hello @pradeeban, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Get a link to the complete list of reviewers
@editorialbot list reviewers

editorialbot avatar Aug 11 '22 14:08 editorialbot

@editorialbot generate pdf

pradeeban avatar Aug 11 '22 14:08 pradeeban

@editorialbot check references

danielskatz avatar Aug 11 '22 14:08 danielskatz

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/access.2022.3161471 is OK
- 10.1109/tbme.2017.2759667 is OK
- 10.1145/3154979.3154984 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot avatar Aug 11 '22 14:08 editorialbot

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot avatar Aug 11 '22 14:08 editorialbot

@pradeeban - I see your submission note to the editor

The CONTROL-CORE framework, which concore is part of, is published in IEEE Access - https://doi.org/10.1109/ACCESS.2022.3161471. That paper is cited in this JOSS paper. [...] The project's early development happened in a private repository. We made the source code public in the concore-2.0.0 version. The main branch is the stable one, with the dev branch with commits of experimental nature that need additional testing before the merge.

Can you explain how this submission is different than the IEEE Access publication?

danielskatz avatar Aug 11 '22 14:08 danielskatz

Hi @danielskatz, A few points:

  • The IEEE Access paper is about the broad CONTROL-CORE framework/umbrella and significantly focuses on neuroscience. This paper focuses on the concore open source project in a more simplistic, less overwhelming manner.

  • At the time of the IEEE Access paper submission, the CONTROL-CORE framework was merely an open-source project. We quickly opened the source code (which was initially developed in a private git repository) before publication through bulk "Initial commits."

  • Since the IEEE Access paper, concore has evolved as a truly open-source project, welcoming open-source contributions (merged in the dev branch). concore Editor is a new addition, adopting the DHGWorkflow for concore.

All the above points make the papers different as in concore open-source project vs. CONTROL-CORE umbrella/framework for neuromodulation control systems.

At the Department of Biomedical Informatics, Emory University, we try to strengthen ourselves as an open-source framework. Many of our projects are open source, and we have been a mentoring organization for Google Summer of Code (GSoC) since 2012 (https://github.com/NISYSLAB/Emory-BMI-GSoC). concore is a new addition to our open source efforts. We hope JOSS will give us more scrutiny and visibility on the open source angle. Although we include the link to the source code in our previous papers, the code repositories are never reviewed, unlike JOSS. We like JOSS for this initiative, highlighting our software efforts alongside the research rather than leaving the source code as a mere footnote.

I hope I have clarified it. Please let me know if you have more questions/comments.

Thank you. Regards, Pradeeban.

pradeeban avatar Aug 11 '22 15:08 pradeeban

Thanks - I think the next step should be for editors to look at this and make sure we think there is enough difference from the previous publication before we start a review. This should take a week or two.

danielskatz avatar Aug 11 '22 15:08 danielskatz

@editorialbot query scope

danielskatz avatar Aug 11 '22 15:08 danielskatz

Submission flagged for editorial review.

editorialbot avatar Aug 11 '22 15:08 editorialbot

@pradeeban, thanks for your submission to JOSS. I've given your earlier paper from March this year (CONTROL-CORE: A Framework for Simulation and Design of Closed-Loop Peripheral Neuromodulation Control Systems) a quick review and it looks like this submission here would be about broadly speaking the same work (i.e., not allowed as a dual publication).

Could you help me understand exactly what the code changes are to your framework since the publication in March this year? Linking to diffs on GitHub will help me make a good decision here.

arfon avatar Aug 21 '22 08:08 arfon

Thanks, @arfon, for your consideration and pointers. After discussing with the co-authors, we have decided to withdraw the paper at this time.

pradeeban avatar Aug 22 '22 16:08 pradeeban

@editorialbot withdraw

arfon avatar Aug 23 '22 13:08 arfon

Paper withdrawn.

editorialbot avatar Aug 23 '22 13:08 editorialbot