javafx-maven-plugin icon indicating copy to clipboard operation
javafx-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon openjfx

Fix toolchain support for non-java executables

Open anthonyvdotbe opened this issue 3 years ago • 4 comments

https://github.com/openjfx/javafx-maven-plugin/pull/118 introduced toolchain support. However, due to the hard-coded "java", this doesn't work for non-java executables such as jlink (i.e. https://github.com/openjfx/javafx-maven-plugin/issues/148)

anthonyvdotbe avatar Apr 26 '22 06:04 anthonyvdotbe

@abhinayagarwal @jperedadnr will you please review? (mentioning you since you reviewed the original PR as well)

anthonyvdotbe avatar Aug 06 '22 14:08 anthonyvdotbe

This should probably be added to other places where executable is still in use. Detecting the JDK home for preparePaths() does not work using toolchains.

alerosmile avatar Aug 10 '22 15:08 alerosmile

@alerosmile the sole goal of this PR is to fix the regression introduced in #118 If you believe toolchain support is incomplete or should be improved, please file a new issue and/or PR instead.

anthonyvdotbe avatar Aug 10 '22 15:08 anthonyvdotbe