javafx-gradle-plugin
javafx-gradle-plugin copied to clipboard
openjfx
Make JavaFx platform configurable
This PR Addresses https://github.com/openjfx/javafx-gradle-plugin/issues/99
Platform can now be configured as follows:
Thank you for PR. I need this functionality too. But mabye it is good write some lines to README file near section with name "4. Cross-platform projects and libraries".
@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?
@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?
@shahzaibj : I came here from downstream as an user of the Sparrow wallet, where we're unable to build on Raspberry Pi 4 (arm) because of the JavaFx platform error solely. As @craigraw (the maintainer of sparrow) writes, your/this PR could solve our issues downstream.
As I got the current situation with this PR, the effort to be taken to move forward seems quite low to me: @jperedadnr has requested 3 months ago the singing of the CLA[https://cla.gluonhq.com/] from you.
:question: Could you please decide if you're able to sign the CLA[https://cla.gluonhq.com/] or not and communicate likewise?
:pray: Thanks
I had opened a similar PR to support cross-platform compilation (https://github.com/openjfx/javafx-gradle-plugin/pull/134/commits/050980728d1e23307ba0d717ba4366cfd0404e27). With the current code, I still have an issue with the way the update of the JavaFX libraries are handled. The updateJavaFXDependencies is called multiple times, while you could add a hook to update these libraries, which will run after all the dependencies have been updated by other plugins as well. I would think this would play nicer with other plugins, which would modify the dependency libraries.
In my code, I would still want to change the way the platform is forced. Preferably I would still need to extract the split method for the OS detection function, so that I can be reused by the forcedplatform and the normal platform detection methods. Any thoughts? I could really use this functionality in my project.
I made a functional identical PR quite some time ago, which also included another feature (configurable platform)
Why not just merge mine, instead of waiting for the CLA here?
I've already signed the CLA.
