8368475: [lworld] Add preview classes to jimage at make time

[david-beaumont]

Copies valuetype classes for each module into corresponding "/META-INF/preview/..." sub-directories to be pulled into jimage files and processed by the new preview mode handling code.

There might be a better way to do this in terms of Makefile semantics, but this seems to work well enough and doesn't prevent the value-class JAR files being generated for patching (which is still how everyone will get value classes until the rest of the work is plumbed in).

To enable the new preview mode work, set the "DISABLE_PREVIEW_PATCHING" system property to "true".

---

Progress

• [x] Change must not contain extraneous whitespace

Integration blocker

 ⚠️ Dependency #1718 must be integrated first

Issue

• JDK-8368475: [lworld] Add preview classes to jimage at make time (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1719/head:pull/1719
$ git checkout pull/1719

Update a local copy of the PR:
$ git checkout pull/1719
$ git pull https://git.openjdk.org/valhalla.git pull/1719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1719

View PR using the GUI difftool:
$ git pr show -t 1719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1719.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back david-beaumont! A progress list of the required criteria for merging this PR into pr/1718 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (4fda33ae)
• 02: Full - Incremental (3b7c8cc3)
• 01: Full (747b24d0)
• 00: Full (14f2a490)

[openjdk[bot]]

@david-beaumont Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@david-beaumont Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@david-beaumont this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jdk_8368475_makefile
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push