8353202: [lworld] TestArrays.java crashes with -XX:+UseNullableValueFlattening

[TobiHartmann]

Nullable, atomic, flat arrays and fields of an empty value class should be treated as atomic by C2. Currently, C2 treats them as naturally atomic because they only have one field (the null marker).

Best regards, Tobias

---

Progress

• [x] Change must not contain extraneous whitespace

Issue

• JDK-8353202: [lworld] TestArrays.java crashes with -XX:+UseNullableValueFlattening (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1418/head:pull/1418
$ git checkout pull/1418

Update a local copy of the PR:
$ git checkout pull/1418
$ git pull https://git.openjdk.org/valhalla.git pull/1418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1418

View PR using the GUI difftool:
$ git pr show -t 1418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1418.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353202: [lworld] TestArrays.java crashes with -XX:+UseNullableValueFlattening

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

• 0bbfece897944f0f25e0d45fc8a4027d3828efde: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (98f0e550)
• 00: Full (9f65ab2b)

[TobiHartmann]

/integrate

[openjdk[bot]]

Going to push as commit b5395e82b1cce79d3139917b6d151f99ca90ee91. Since your change was applied there have been 2 commits pushed to the lworld branch:

• f48c0f45a0a15ca4b40329469f247449bfee0538: 8336795: [lworld] JNI MonitorEnter doesn't return the right value when it throws an exception
• 0bbfece897944f0f25e0d45fc8a4027d3828efde: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@TobiHartmann Pushed as commit b5395e82b1cce79d3139917b6d151f99ca90ee91.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.