8351362: Post-process @Strict annotation for testing

[liach]

Added a test tool to strictify files and migrated the existing StrictFinalInstanceFieldsTest as an example.

---

Progress

• [x] Change must not contain extraneous whitespace

Issue

• JDK-8351362: Post-process @Strict annotation for testing (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1395/head:pull/1395
$ git checkout pull/1395

Update a local copy of the PR:
$ git checkout pull/1395
$ git pull https://git.openjdk.org/valhalla.git pull/1395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1395

View PR using the GUI difftool:
$ git pr show -t 1395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1395.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@liach This change is no longer ready for integration - check the PR body for details.

[mlbridge[bot]]

Webrevs

• 03: Full (84bdb7a6)
• 02: Full - Incremental (a44c269c)
• 01: Full - Incremental (30d78fb9)
• 00: Full (bb1fd0dc)

[liach]

Looking to integrate this as I have added all functionalities in the RFE (despite the ctor call relocation being extremely primitive)

/integrate

[openjdk[bot]]

@liach Your change (at version a44c269c196dc334f76c12faa0bb101aa52365d7) is now ready to be sponsored by a Committer.

[dansmithcode]

I would not recommend integrating until https://github.com/openjdk/valhalla/pull/1389 is done.

At that point, there will be a large number of tests to experiment with, and after seeing if/how conveniently they can be updated to adopt this tool, we can then have a conversation with the rest of the team about whether this is a good solution going forward, or whether there are still concerns about this not being built into javac.

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

This does seems a bit weird in the context of lworld, where many structures already make use of strict - I think this would be more convincing if we can port strict onto simply master, or add a flag on lworld to run with just mainline + strict, without any value object.

[openjdk[bot]]

@liach This pull request is now open

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

[openjdk[bot]]

@liach This pull request is now open

[openjdk[bot]]

@liach this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout test/strict-processor
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

[openjdk[bot]]

@liach This pull request is now open

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.