valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

Removing default value

Open fparain opened this issue 8 months ago • 8 comments

First part of the removal of the VM defined default value, with runtime and JDK changes only (no JIT changes yet)


Progress

  • [x] Change must not contain extraneous whitespace

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1389/head:pull/1389
$ git checkout pull/1389

Update a local copy of the PR:
$ git checkout pull/1389
$ git pull https://git.openjdk.org/valhalla.git pull/1389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1389

View PR using the GUI difftool:
$ git pr show -t 1389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1389.diff

fparain avatar Mar 04 '25 14:03 fparain

:wave: Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 04 '25 14:03 bridgekeeper[bot]

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353746: [lworld] Remove the default value and @ImplictlyConstructible annotation

Co-authored-by: Tobias Hartmann <[email protected]>
Co-authored-by: Roger Riggs <[email protected]>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the lworld branch:

  • a8ad27534166e0956c6e5cfd4dbd0578f408cff7: Merge jdk
  • a347ecdedc098bd23598ba6acf28d77db01be066: 8350905: Shenandoah: Releasing a WeakHandle's referent may extend its lifetime
  • 5502ce733e77efa9f40116dd0e34d4d2333a48dc: 8351699: Problem list com/sun/jdi/JdbStopInNotificationThreadTest.java with ZGC
  • cdf7632f8a85611077a27c91ad928ed8ea116f95: 8351444: Shenandoah: Class Unloading may encounter recycled oops
  • 930455b59608b547017c9649efeb6bd381340c34: 8351640: Print reason for making method not entrant
  • 895f64a18d7c752332ef9255c0b118bf25bdbb90: 8351142: Add JFR monitor deflation and statistics events
  • db531bf7df517eb6a07080aceb2a88a3b90d5e94: 8351881: Tidy complains about missing "alt" attribute
  • 02c850fca87372173eadba18dfa0231df33bebb0: 8350982: -server|-client causes fatal exception on static JDK
  • 2371696781edc040d8fa8133c78b284a2e3de1ed: 8303770: Remove Baltimore root certificate expiring in May 2025
  • f16a74260f329ccef51faa2e375bce5947057a49: 8351626: Update remaining icons to SVG format
  • ... and 77 more: https://git.openjdk.org/valhalla/compare/f662357d3a5b78aa7f89ce81a04f39185a3d233a...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 04 '25 14:03 openjdk[bot]

@fparain this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout strict_nr
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

openjdk[bot] avatar Mar 21 '25 13:03 openjdk[bot]

/contributor add @TobiHartmann

fparain avatar Apr 01 '25 11:04 fparain

/contributor add @RogerRiggs

fparain avatar Apr 01 '25 11:04 fparain

@fparain Contributor Tobias Hartmann <[email protected]> successfully added.

openjdk[bot] avatar Apr 01 '25 11:04 openjdk[bot]

@fparain Contributor Roger Riggs <[email protected]> successfully added.

openjdk[bot] avatar Apr 01 '25 11:04 openjdk[bot]

⚠️ @fparain This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar Apr 04 '25 06:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 04 '25 17:04 mlbridge[bot]

/integrate

fparain avatar Apr 04 '25 19:04 fparain

Going to push as commit 293a9c406f784c1d8d165574487e58c475739074. Since your change was applied there have been 87 commits pushed to the lworld branch:

  • a8ad27534166e0956c6e5cfd4dbd0578f408cff7: Merge jdk
  • a347ecdedc098bd23598ba6acf28d77db01be066: 8350905: Shenandoah: Releasing a WeakHandle's referent may extend its lifetime
  • 5502ce733e77efa9f40116dd0e34d4d2333a48dc: 8351699: Problem list com/sun/jdi/JdbStopInNotificationThreadTest.java with ZGC
  • cdf7632f8a85611077a27c91ad928ed8ea116f95: 8351444: Shenandoah: Class Unloading may encounter recycled oops
  • 930455b59608b547017c9649efeb6bd381340c34: 8351640: Print reason for making method not entrant
  • 895f64a18d7c752332ef9255c0b118bf25bdbb90: 8351142: Add JFR monitor deflation and statistics events
  • db531bf7df517eb6a07080aceb2a88a3b90d5e94: 8351881: Tidy complains about missing "alt" attribute
  • 02c850fca87372173eadba18dfa0231df33bebb0: 8350982: -server|-client causes fatal exception on static JDK
  • 2371696781edc040d8fa8133c78b284a2e3de1ed: 8303770: Remove Baltimore root certificate expiring in May 2025
  • f16a74260f329ccef51faa2e375bce5947057a49: 8351626: Update remaining icons to SVG format
  • ... and 77 more: https://git.openjdk.org/valhalla/compare/f662357d3a5b78aa7f89ce81a04f39185a3d233a...lworld

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Apr 04 '25 19:04 openjdk[bot]

@fparain Pushed as commit 293a9c406f784c1d8d165574487e58c475739074.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Apr 04 '25 19:04 openjdk[bot]