valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

8350444: Check for verifer error in StackMapReader::check_offset()

Open matias9927 opened this issue 9 months ago • 4 comments

This patch upstreams a change from mainline that is needed to implement strict fields. Originally reviewed-by: coleenp, dholmes


Progress

  • [x] Change must not contain extraneous whitespace

Issue

  • JDK-8350444: Check for verifer error in StackMapReader::check_offset() (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1372/head:pull/1372
$ git checkout pull/1372

Update a local copy of the PR:
$ git checkout pull/1372
$ git pull https://git.openjdk.org/valhalla.git pull/1372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1372

View PR using the GUI difftool:
$ git pr show -t 1372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1372.diff

Using Webrev

Link to Webrev Comment

matias9927 avatar Feb 21 '25 17:02 matias9927

:wave: Welcome back matsaave! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 21 '25 17:02 bridgekeeper[bot]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350444: Check for verifer error in StackMapReader::check_offset()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 164 new commits pushed to the lworld branch:

  • 4d262327f1c2d0b4a1bb583f5b9eb3db9c224ea8: Merge jdk
  • a637ccf2fead25ea6a06ad6bd65e92b8694ee11c: 8349851: RISC-V: Call VM leaf can use movptr2
  • adc3f53d2403cd414a91e71c079b4108b2346da0: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so
  • 55097dd4cbb5d691c12cb0247d66dce593759d59: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni
  • b8576eb48e6aae96f9bad1caeedaeb4b5b675e34: 6562489: Font-Renderer should ignore invisible characters \u2062 and \u2063
  • 7a0832f5487cb7586131f6c4e0b90300f6de5dec: 8349934: Wrong file regex for copyright header format check in .jcheck/conf
  • 2a5d1da3355a4df3109ec42646b5b0cf088b4c2a: 8349571: Remove JavaThreadFactory interface from SA
  • 74e458bad6ba6e8aa85e0950119963a6f6cb2c03: 8349684: Remove SA core file tests from problem list for macosx-x64
  • ba28119642a7cfa850707a01ce8e589c3a80d416: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
  • c5ac3c4f11e777b24d597deec522c9df09750f59: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
  • ... and 154 more: https://git.openjdk.org/valhalla/compare/0bcf2675a5d68b9316c49b1cad3cffe7b0df022c...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Feb 21 '25 17:02 openjdk[bot]

Webrevs

mlbridge[bot] avatar Feb 21 '25 17:02 mlbridge[bot]

@matias9927 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 21 '25 19:03 bridgekeeper[bot]

@matias9927 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Apr 19 '25 01:04 bridgekeeper[bot]