valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

8340125: [lw5] null checks are not being generated for method invocations and array writes

Open vicente-romero-oracle opened this issue 1 year ago • 4 comments

javac is not generating null checks for runtime execution for method invocations and array writes


Progress

  • [x] Change must not contain extraneous whitespace

Issue

  • JDK-8340125: [lw5] null checks are not being generated for method invocations and array writes (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1251/head:pull/1251
$ git checkout pull/1251

Update a local copy of the PR:
$ git checkout pull/1251
$ git pull https://git.openjdk.org/valhalla.git pull/1251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1251

View PR using the GUI difftool:
$ git pr show -t 1251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1251.diff

Webrev

Link to Webrev Comment

vicente-romero-oracle avatar Sep 24 '24 21:09 vicente-romero-oracle

:wave: Welcome back vromero! A progress list of the required criteria for merging this PR into lw5 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 24 '24 21:09 bridgekeeper[bot]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340125: [lw5] null checks are not being generated for method invocations and array writes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lw5 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lw5 branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 24 '24 21:09 openjdk[bot]

⚠️ @vicente-romero-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar Sep 25 '24 14:09 openjdk[bot]

/integrate

vicente-romero-oracle avatar Oct 03 '24 03:10 vicente-romero-oracle

Going to push as commit ff2776455fd90ec4c7d744007c0f93b948e977d8.

openjdk[bot] avatar Oct 03 '24 03:10 openjdk[bot]

@vicente-romero-oracle Pushed as commit ff2776455fd90ec4c7d744007c0f93b948e977d8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 03 '24 03:10 openjdk[bot]