valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

8339494: Porting HalfFloatVector classes.

Open jatin-bhateja opened this issue 1 year ago • 3 comments

  • Port existing HalfFloatVector and its concrete vector classes from vectorIntrinsics+fp16 to lworld+fp16.
  • These new vector classes uses Float16 array as their backing storage.
  • Idea is to enable intrinsificaiton of new HalfFloatVector operations and leverage existing Float16 auto-vectorization and backend support.

All existing VectorAPI tests are passing with the patch.

Best Regards, Jatin

Follow up work:- a) Jtreg suite extensions to cover HalfFloatVector operations. b) Handle Float16 lane type in vector API inline expansion layer.


Progress

  • [x] Change must not contain extraneous whitespace

Issue

  • JDK-8339494: Porting HalfFloatVector classes. (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1233/head:pull/1233
$ git checkout pull/1233

Update a local copy of the PR:
$ git checkout pull/1233
$ git pull https://git.openjdk.org/valhalla.git pull/1233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1233

View PR using the GUI difftool:
$ git pr show -t 1233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1233.diff

Webrev

Link to Webrev Comment

jatin-bhateja avatar Sep 03 '24 17:09 jatin-bhateja

:wave: Welcome back jbhateja! A progress list of the required criteria for merging this PR into lworld+fp16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 03 '24 17:09 bridgekeeper[bot]

@jatin-bhateja This change is no longer ready for integration - check the PR body for details.

openjdk[bot] avatar Sep 03 '24 17:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 03 '24 17:09 mlbridge[bot]

@jatin-bhateja this pull request can not be integrated into lworld+fp16 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8339494
git fetch https://git.openjdk.org/valhalla.git lworld+fp16
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld+fp16"
git push

openjdk[bot] avatar Sep 29 '24 13:09 openjdk[bot]

@jatin-bhateja This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 16:10 bridgekeeper[bot]

@jatin-bhateja This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Dec 26 '24 22:12 bridgekeeper[bot]