valhalla icon indicating copy to clipboard operation
valhalla copied to clipboard

8337605: Update description of constants in Float16

Open jddarcy opened this issue 1 year ago • 3 comments

Align wording or Float16 constants more closely with wording used in Float/Double, add links to corresponding Float/Double constants.


Progress

  • [x] Change must not contain extraneous whitespace

Issue

  • JDK-8337605: Update description of constants in Float16 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1191/head:pull/1191
$ git checkout pull/1191

Update a local copy of the PR:
$ git checkout pull/1191
$ git pull https://git.openjdk.org/valhalla.git pull/1191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1191

View PR using the GUI difftool:
$ git pr show -t 1191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1191.diff

Webrev

Link to Webrev Comment

jddarcy avatar Aug 01 '24 00:08 jddarcy

:wave: Welcome back darcy! A progress list of the required criteria for merging this PR into lworld+fp16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 01 '24 00:08 bridgekeeper[bot]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337605: Update description of constants in Float16

Reviewed-by: bkilambi, rgiulietti, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld+fp16 branch:

  • c6a704dca7e0b1be2e8e35f00aea1ef923348b48: 8338102: x86 backend support for newly added Float16 intrinsics.
  • ce32e8c9bb2e99b20d088b88819feac9da6125f5: 8336406: Add support for FP16 binary operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld+fp16 branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Aug 01 '24 00:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 01 '24 00:08 mlbridge[bot]

/integrate

jddarcy avatar Aug 06 '24 14:08 jddarcy

@jddarcy Your change (at version 9fd1323788788efb61d2fb65d8ae8f8df8662edf) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Aug 06 '24 14:08 openjdk[bot]

@jatin-bhateja , can you sponsor this change? Thanks.

jddarcy avatar Aug 12 '24 19:08 jddarcy

/sponsor

jatin-bhateja avatar Aug 13 '24 06:08 jatin-bhateja

Going to push as commit 835c16d5e5ec470f999f6109481e07ef5d6d33e4. Since your change was applied there have been 2 commits pushed to the lworld+fp16 branch:

  • c6a704dca7e0b1be2e8e35f00aea1ef923348b48: 8338102: x86 backend support for newly added Float16 intrinsics.
  • ce32e8c9bb2e99b20d088b88819feac9da6125f5: 8336406: Add support for FP16 binary operations

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 13 '24 06:08 openjdk[bot]

@jatin-bhateja @jddarcy Pushed as commit 835c16d5e5ec470f999f6109481e07ef5d6d33e4.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 13 '24 06:08 openjdk[bot]