skara
skara copied to clipboard
2300: Do not list non-OpenJDK reviewers in Reviewers list
This PR is trying to make skara bot list non-recognized user in a separate section in the PR body.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
Issue
- SKARA-2300: Do not list non-OpenJDK reviewers in Reviewers list (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1693/head:pull/1693
$ git checkout pull/1693
Update a local copy of the PR:
$ git checkout pull/1693
$ git pull https://git.openjdk.org/skara.git pull/1693/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1693
View PR using the GUI difftool:
$ git pr show -t 1693
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1693.diff
Webrev
:wave: Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@zhaosongzs This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
:mag: One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.
:earth_americas: Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.
After integration, the commit message for the final commit will be:
2300: Do not list non-OpenJDK reviewers in Reviewers list
Reviewed-by: prappo, kcr, erikj
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Thank you all for reviews! /integrate
Going to push as commit 6e4b2b8125e814b8d4d9bd8f85f9e4a12c22e4f9.
@zhaosongzs Pushed as commit 6e4b2b8125e814b8d4d9bd8f85f9e4a12c22e4f9.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.