2328: Ignore bot user's comment when determining the latest action time of a PR

[zhaosongzs]

PullRequestPrunerBot is responsible for closing PRs that have not been active for a certain time. However, it currently doesn't ignore comments from bot users when determining the latest action time of a PR.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace

Issue

• SKARA-2328: Ignore bot user's comment when determining the latest action time of a PR (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1687/head:pull/1687
$ git checkout pull/1687

Update a local copy of the PR:
$ git checkout pull/1687
$ git pull https://git.openjdk.org/skara.git pull/1687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1687

View PR using the GUI difftool:
$ git pr show -t 1687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1687.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

:mag: One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

2328: Ignore bot user's comment when determining the latest action time of a PR

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 6e4b2b8125e814b8d4d9bd8f85f9e4a12c22e4f9: 2300: Do not list non-OpenJDK reviewers in Reviewers list
• 6da14cf5d2843aaaec488fd1bb7af91730a9679b: 2395: Make it configurable to disable the contributor check for the /backport command
• 98261e6efe578994823ff006b608da66350e8791: 2391: Update .github/workflows/ci.yml
• 869775870d239337cb4fbc2cf10a6c0a0a07eaae: 2387: Revert SKARA-2386 and cache issueProject in JiraHost
• cf23f68fbf97c7a58d5d8ce1ba8072cc381d7f65: 2386: PullRequestBotFactory creates too many IssueBots
• e40bda95c4c7010a69c69b4a5cb0260c007227a1: 2363: When jcheck result is too big, it can't be published to Github

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (e189bbfc)
• 00: Full (bc145c9f)

[erikj79]

This change will only make the bot ignore comments from the particular user (or actually "app") this bot uses, which in practice won't change anything as the bridgekeeper bot uses a different app compared to the pr bot. To solve this properly we need to add a configuration for "ignored", like several other bots have, so we can list all users that should be ignored by the pruner. See mlbridge for an example.

[zhaosongzs]

This change will only make the bot ignore comments from the particular user (or actually "app") this bot uses, which in practice won't change anything as the bridgekeeper bot uses a different app compared to the pr bot. To solve this properly we need to add a configuration for "ignored", like several other bots have, so we can list all users that should be ignored by the pruner. See mlbridge for an example.

Ah right, I forgot this bot is using a different user... Will fix it, thanks for catching it.

[bridgekeeper[bot]]

@zhaosongzs This pull request has been inactive for more than 3 weeks and will be automatically closed if another 3 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[zhaosongzs]

Thank you for the review! /integrate

[openjdk[bot]]

Going to push as commit e156edb566f68185eae16d9390ba5cfd2da2a359. Since your change was applied there have been 7 commits pushed to the master branch:

• c7e1c2fd2e8bad37721eac450c0869f2242d0662: 2397: Jira Issues with resoultion "delivered" should not be changed to "fixed"
• 6e4b2b8125e814b8d4d9bd8f85f9e4a12c22e4f9: 2300: Do not list non-OpenJDK reviewers in Reviewers list
• 6da14cf5d2843aaaec488fd1bb7af91730a9679b: 2395: Make it configurable to disable the contributor check for the /backport command
• 98261e6efe578994823ff006b608da66350e8791: 2391: Update .github/workflows/ci.yml
• 869775870d239337cb4fbc2cf10a6c0a0a07eaae: 2387: Revert SKARA-2386 and cache issueProject in JiraHost
• cf23f68fbf97c7a58d5d8ce1ba8072cc381d7f65: 2386: PullRequestBotFactory creates too many IssueBots
• e40bda95c4c7010a69c69b4a5cb0260c007227a1: 2363: When jcheck result is too big, it can't be published to Github

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@zhaosongzs Pushed as commit e156edb566f68185eae16d9390ba5cfd2da2a359.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.