skara
skara copied to clipboard
2304: /backport jdk23 should provide a more helpful message
This patch is trying to improve the bot's replies of backport command.
-
If the user issued
/backport jdkX, the bot would check if there is ajdkXbranch in current repo, if so, the bot would tell the user that to target a backport tojdkXbranch in current repo, he should issue/backport :jdkX. -
When user specified branch name in the command but the branch doesn't exist, the bot will list 10 branch names in the target repo, the branch names are just sorted in reverse alphabetical order, so we can't guarantee they are the most relevant ones.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
Issue
- SKARA-2304: /backport jdk23 should provide a more helpful message (Bug - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1667/head:pull/1667
$ git checkout pull/1667
Update a local copy of the PR:
$ git checkout pull/1667
$ git pull https://git.openjdk.org/skara.git pull/1667/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1667
View PR using the GUI difftool:
$ git pr show -t 1667
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1667.diff
Webrev
:wave: Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@zhaosongzs This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
:mag: One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.
:earth_americas: Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.
After integration, the commit message for the final commit will be:
2304: /backport jdk23 should provide a more helpful message
Reviewed-by: erikj
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 1 new commit pushed to the master branch:
- 9817010c4fe57fd5e54b30653df6c43b9b481b2b: 2313: Notify graal mailing list for intrinsic related PRs
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Thanks for the review! /integrate
Going to push as commit 273c362ab262134584830fc99adfd23f6f7ee0f7.
Since your change was applied there has been 1 commit pushed to the master branch:
- 9817010c4fe57fd5e54b30653df6c43b9b481b2b: 2313: Notify graal mailing list for intrinsic related PRs
Your commit was automatically rebased without conflicts.
@zhaosongzs Pushed as commit 273c362ab262134584830fc99adfd23f6f7ee0f7.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.