leyden icon indicating copy to clipboard operation
leyden copied to clipboard

8335358: [premain] Explore alternative ways to trigger the end of training run

Open macarte opened this issue 1 year ago • 10 comments

AOT training can be ended using either

  • -XX: AOTEndTrainingOnMethodEntry =Hello.someMethod [same syntax as CompileOnly]
  • -XX: AOTEndTrainingOnMethodEntry =Hello.someMethod,Hello.someOtherMethod,count=42
  • jcmd <pid> AOT.end_training

supports arm64 and x64

note: the AOTEndTrainingOnMethodEntry is ignored when CDSPreImage is specified; this is needed as the phase2 forked java process is passed all phase1 flags along with the -XX:CDSPreImage, but we don't want to run the trigger code in this phase (there may be a better way to handle this state or simply remove the flag from the forked process)

JBS Issue: https://bugs.openjdk.org/browse/JDK-8335358


Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8335358: [premain] Explore alternative ways to trigger the end of training run (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/leyden.git pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/21.diff

Webrev

Link to Webrev Comment

macarte avatar Sep 11 '24 21:09 macarte