jtreg icon indicating copy to clipboard operation
jtreg copied to clipboard

7904083: Print fatal error messages to stderr

Open sendaoYan opened this issue 2 months ago • 8 comments

Hi all,

Currently the fatal error message was print to stderr, shows as below. I think it's bettor to print the fatal error message to stderr.

unset JAVA_HOME ; jtreg -version No java executable at java

unset JAVA_HOME ; jtreg -version > /dev/null #nothing

The >&2 usage for echo both works on linux and cygwin. I do not have other OS system to verify this change, but I think the risk of this change is low.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/290/head:pull/290
$ git checkout pull/290

Update a local copy of the PR:
$ git checkout pull/290
$ git pull https://git.openjdk.org/jtreg.git pull/290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 290

View PR using the GUI difftool:
$ git pr show -t 290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/290.diff

Using Webrev

Link to Webrev Comment

sendaoYan avatar Sep 23 '25 06:09 sendaoYan

:wave: Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 06 '25 20:09 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Sep 06 '25 20:09 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Sep 06 '25 20:09 openjdk[bot]

@jankratochvil Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

openjdk[bot] avatar Sep 06 '25 20:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 06 '25 20:09 mlbridge[bot]

The CI errors are false positives, they are the same as unpatched sources tested in: https://github.com/jankratochvil/jdk8u-dev/pull/1

jankratochvil avatar Sep 09 '25 08:09 jankratochvil

/contributor add Anton Voznia [email protected]

jankratochvil avatar Oct 03 '25 14:10 jankratochvil

@jankratochvil Contributor Anton Voznia <[email protected]> successfully added.

openjdk[bot] avatar Oct 03 '25 14:10 openjdk[bot]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '25 17:10 bridgekeeper[bot]