7903081: Update asmtools and remove jcov traces

[sormuras]

work in progress...

Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• CODETOOLS-7903081: Update asmtools and remove jcov traces (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.org/jtreg.git pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/228.diff

[bridgekeeper[bot]]

:wave: Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903081: Update asmtools and remove jcov traces

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 94460dc9101ab39cc611760427090d79bbbe21ef: 7903990: IDEA plugin: Itemize junit test results
• c6388c7eeb72af193dc7f5cd374658fd5ede885a: 7904004: Run jtreg GHA workflows for FreeBSD
• 170c35711b8cae076a6663c270306bd89526e051: 7904000: Update to build with JDK 17
• ... and 13 more: https://git.openjdk.org/jtreg/compare/759946dedbafa423552851ecb98bc3bb8dcf30ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper[bot]]

@sormuras This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@sormuras This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[sormuras]

/open

[openjdk[bot]]

@sormuras This pull request is now open

[sormuras]

Now also blocked by an unreleased bugfix in the Ant build.xml producing:

/home/runner/work/jtreg/jtreg/build/deps/asmtools/src/asmtools-8.0-b09/build/build.xml:179: .

Current java version is 21
The build should be started by java 17 or above

@lkuskov would it be possible to release asmtools 8.1 with the updated regex (commit https://github.com/openjdk/asmtools/commit/949fb1dfcc54fd5bffbda012fe689ff059999c9f)?

[lkuskov]

Hi Christian, Unfortunately, despite being the integrator of the commit, I can't set a tag /tag at8.1 for it: 949fb1d Any tips? Thanks, Leonid

[bridgekeeper[bot]]

@sormuras This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (34944da2)
• 00: Full (0e88a367)

[jaikiran]

Hello Christian, the upgrade looks reasonable to me. Now that we enforce Java 17 for building jtreg, I think we should also update the doc/building.md which currently states:

It must be a recent build of JDK 11 or later.

[LudwikJaniuk]

Being able to test older JDK's with jtreg is important. Do I understand it right that this PR would make it impossible to run with a JDK pre-17, with no workaround possible?

[sormuras]

The jtreg tool itself requires Java 11 since 7.0; agents can be still on 8, same as today. Soon, tests using asmtools 8.x will require Java 17 - due to https://github.com/openjdk/asmtools/blob/279512c2c649f59a0c15f1ae2caa31b9ed695ea5/build/build.properties#L30-L31

[sormuras]

/integrate

[openjdk[bot]]

Going to push as commit 816e6d7a5b5bfe2e1da7ceb076d0ec172529cf8f. Since your change was applied there have been 16 commits pushed to the master branch:

• 94460dc9101ab39cc611760427090d79bbbe21ef: 7903990: IDEA plugin: Itemize junit test results
• c6388c7eeb72af193dc7f5cd374658fd5ede885a: 7904004: Run jtreg GHA workflows for FreeBSD
• 170c35711b8cae076a6663c270306bd89526e051: 7904000: Update to build with JDK 17
• ... and 13 more: https://git.openjdk.org/jtreg/compare/759946dedbafa423552851ecb98bc3bb8dcf30ec...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@sormuras Pushed as commit 816e6d7a5b5bfe2e1da7ceb076d0ec172529cf8f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.