7903781: Report the process id of the agent or other VM that was used for a jtreg action

[jaikiran]

trafficstars

Can I please get a review of this change which proposes to repor the process id of the process that was used to run a jtreg action? This change addresses https://bugs.openjdk.org/browse/CODETOOLS-7903781.

As noted in that linked enhancement request, this change will report the process id the section messages of each action. This will now look like:

#section:compile
----------messages:(7/297)----------
command: compile test/streams/FileDescriptorTest.java
reason: .class file out of date or does not exist
started: Fri Jul 26 00:56:01 UTC 2024
Mode: othervm
Process id: 88469
finished: Fri Jul 26 00:56:01 UTC 2024
elapsed time (seconds): 0.254

....

#section:main
----------messages:(7/232)----------
command: main FileDescriptorTest
reason: User specified action: run main FileDescriptorTest 
started: Fri Jul 26 00:56:01 UTC 2024
Mode: othervm
Process id: 88470
finished: Fri Jul 26 00:56:01 UTC 2024
elapsed time (seconds): 0.042

Notice the new "Process id: ..." line in those sections.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• CODETOOLS-7903781: Report the process id of the agent or other VM that was used for a jtreg action (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jtreg.git pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/215.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903781: Report the process id of the agent or other VM that was used for a jtreg action

Reviewed-by: jjg, cstein

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 3750f09675011ff237a65b1c623507e83d17796f: 7901757: Race in counting total number of failures from TestNG
• 5d74713fc66aac9829b188bd3fc19ce3e2c5a812: 7903793: Latent typo in ReportOnlyTest.gmk
• 789f00d3b54d32ef1dd1270439981676eab6d19b: 7903792: ReportOnlyTest may fail in "headless" environments
• ca8c1ecf924c4ea40fc13a907559aaa90f3d0196: 7903765: wget failed in build.sh in jtreg
• feee5044a785d6dcef2b3b82f7d8d11daf09e594: 7903784: NullPointerException: Cannot read the array length because the return value of "java.io.File.listFiles()" is null
• a9172d632af9059c0df2cc3c8316866654a98dd0: 7903759: Amend changelog to include the removal of jtdiff

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (6130232d)
• 01: Full - Incremental (7404620f)
• 00: Full (02b61ded)

[jaikiran]

Thank you Jon and Christian for the reviews.

[jaikiran]

/integrate

[openjdk[bot]]

Going to push as commit 583ffcad930a9a7c75bfe00c132436c242ccde31. Since your change was applied there have been 6 commits pushed to the master branch:

• 3750f09675011ff237a65b1c623507e83d17796f: 7901757: Race in counting total number of failures from TestNG
• 5d74713fc66aac9829b188bd3fc19ce3e2c5a812: 7903793: Latent typo in ReportOnlyTest.gmk
• 789f00d3b54d32ef1dd1270439981676eab6d19b: 7903792: ReportOnlyTest may fail in "headless" environments
• ca8c1ecf924c4ea40fc13a907559aaa90f3d0196: 7903765: wget failed in build.sh in jtreg
• feee5044a785d6dcef2b3b82f7d8d11daf09e594: 7903784: NullPointerException: Cannot read the array length because the return value of "java.io.File.listFiles()" is null
• a9172d632af9059c0df2cc3c8316866654a98dd0: 7903759: Amend changelog to include the removal of jtdiff

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@jaikiran Pushed as commit 583ffcad930a9a7c75bfe00c132436c242ccde31.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.