7903738 : jtr.xml logs produced with -xml argument do not contain compilation failure justification - alternative approach

[andrlos]

trafficstars

this is an alternative to https://github.com/openjdk/jtreg/pull/198 here we are collecting all the System.err outputs and putting them into a StringBuilder and returning them as one long string.. Order of the sections should be intact, so it should go chronologically according to the test execution. This could be also improved by adding section separator Strings into the StringBuilder between individual sections. Also we could drop the if (titles[i].equals("main") || ... part and output any System.err output found in jtr.xml as part of the test failure

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue CODETOOLS-7903738

Issue

• CODETOOLS-7903738: jtr.xml logs produced with -xml argument do not contain compilation failure justification (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jtreg.git pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/199.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back andrlos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (7ced8369)
• 00: Full (d2fd6b55)

[openjdk[bot]]

@andrlos Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[bridgekeeper[bot]]

@andrlos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[andrlos]

@sormuras or anybody - please review?

[bridgekeeper[bot]]

@andrlos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@andrlos This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[andrlos]

/open

[andrlos]

rebased to the latest master on openjdk/jtreg. Somebody, please review? keep in mind that this is an alternative to https://github.com/openjdk/jtreg/pull/198 and only one of them should be merged..