jmh icon indicating copy to clipboard operation
jmh copied to clipboard

7904058: Enable BenchmarkParams construction to be overriden

Open galderz opened this issue 4 months ago • 14 comments
trafficstars

This is the second in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.

This PR enables BenchmarkParams construction to be overriden, in order to easily support JMH use case for benchmarking native images. The JIRA contains a detailed explanation. Having this PR in simplifies construction of BenchmarkParams instance. The changes https://github.com/galderz/fibula/commit/8fd8cf3f4eb1c6f37de7f807bfc697ef981a3e05#diff-601b6d98eff18db8a804efb415d515c3d397d42b9c982713b72c37bea2ebbf18 demonstrate the simplification enabled by the changes here.

Here is the PR list for reference:

  1. Make OutputFormatAdapter public
  2. Enable BenchmarkParams construction to be overriden
  3. Enable alternative Runner instantiation and Main reuse
  4. Enable profiler classes to be reused outside of JMH
  5. Enable JMH integration tests to be executed against other impls

Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7904058: Enable BenchmarkParams construction to be overriden (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jmh.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/160.diff

Using Webrev

Link to Webrev Comment

galderz avatar Jul 08 '25 09:07 galderz

:wave: Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 08 '25 09:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 08 '25 09:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 08 '25 09:07 mlbridge[bot]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 05 '25 16:08 bridgekeeper[bot]

/touch

galderz avatar Aug 06 '25 09:08 galderz

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Aug 06 '25 09:08 openjdk[bot]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 03 '25 17:09 bridgekeeper[bot]

/touch

galderz avatar Sep 04 '25 11:09 galderz

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Sep 04 '25 11:09 openjdk[bot]

/touch

galderz avatar Sep 04 '25 11:09 galderz

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Sep 04 '25 11:09 openjdk[bot]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 02 '25 22:10 bridgekeeper[bot]

/touch

galderz avatar Oct 09 '25 10:10 galderz

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Oct 09 '25 10:10 openjdk[bot]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 06 '25 12:11 bridgekeeper[bot]

/touch

galderz avatar Nov 06 '25 17:11 galderz

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Nov 06 '25 17:11 openjdk[bot]