jmh icon indicating copy to clipboard operation
jmh copied to clipboard

7903960: JMH: Add Maven Wrapper integration

Open vy opened this issue 8 months ago • 4 comments

Adds Maven Wrapper integration. See the ticket description for details.


Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ Executable files are not allowed (file: mvnw)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jmh.git pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/154.diff

vy avatar Mar 06 '25 08:03 vy

:wave: Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 06 '25 08:03 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 06 '25 08:03 openjdk[bot]

@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 03 '25 13:04 bridgekeeper[bot]

Maven Wrapper must be run as an executable, it does not support being passed as a parameter to sh. Filed MWRAPPER-161 to address this.

vy avatar Apr 04 '25 12:04 vy

@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 02 '25 15:05 bridgekeeper[bot]

@vy This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 30 '25 16:05 bridgekeeper[bot]

/open

vy avatar Oct 02 '25 07:10 vy

@vy This pull request is now open

openjdk[bot] avatar Oct 02 '25 07:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 02 '25 07:10 mlbridge[bot]

@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 30 '25 13:10 bridgekeeper[bot]

Withdrawing this work due to lack of interest.

vy avatar Nov 04 '25 09:11 vy