jmh
jmh copied to clipboard
7903960: JMH: Add Maven Wrapper integration
Adds Maven Wrapper integration. See the ticket description for details.
Progress
- [x] Change must not contain extraneous whitespace
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Error
⚠️ Executable files are not allowed (file: mvnw)
Issue
- CODETOOLS-7903960: JMH: Add Maven Wrapper integration (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/154/head:pull/154
$ git checkout pull/154
Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jmh.git pull/154/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 154
View PR using the GUI difftool:
$ git pr show -t 154
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/154.diff
:wave: Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Maven Wrapper must be run as an executable, it does not support being passed as a parameter to sh. Filed MWRAPPER-161 to address this.
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@vy This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
/open
@vy This pull request is now open
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Withdrawing this work due to lack of interest.