jmc
jmc copied to clipboard
8400: Add more show options for JMX Console graphs
Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
Progress
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- JMC-8400: Add more show options for JMX Console graphs (New Feature - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652
$ git checkout pull/652
Update a local copy of the PR:
$ git checkout pull/652
$ git pull https://git.openjdk.org/jmc.git pull/652/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 652
View PR using the GUI difftool:
$ git pr show -t 652
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/652.diff
Using Webrev
:wave: Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@thegreystone This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8400: Add more show options for JMX Console graphs
Reviewed-by: aptmac
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 2 new commits pushed to the master branch:
- 06297dcc338985c0aefd360e49cddf536efd7635: 8421: Missing Eclipse classpath entry defaults
- c8e8a136cf396a26fa69e34c7816689ad4b1e1e0: 8416: Better Eclipse classpath entry defaults
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Webrevs
- 03: Full (266929a9)
- 02: Full - Incremental (45830ad9)
- 01: Full - Incremental (8cb62f9b)
- 00: Full (83fa46d6)
@thegreystone This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/touch
@thegreystone The pull request is being re-evaluated and the inactivity timeout has been reset.
Don't worry about the failed MacOS test - that has been fixed in the main branch. This PR was opened before #661, and all should be fine when integrated.
@thegreystone Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
/integrate
Going to push as commit 22e4459c4e1e6410efcfa10061ffd3e14fdd3307.
Since your change was applied there have been 2 commits pushed to the master branch:
- 06297dcc338985c0aefd360e49cddf536efd7635: 8421: Missing Eclipse classpath entry defaults
- c8e8a136cf396a26fa69e34c7816689ad4b1e1e0: 8416: Better Eclipse classpath entry defaults
Your commit was automatically rebased without conflicts.
@thegreystone Pushed as commit 22e4459c4e1e6410efcfa10061ffd3e14fdd3307.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.