jmc
jmc copied to clipboard
openjdk
8396: Fix incorrect option name for `HeapDumpOnOutOfMemoryError`
I noticed that HeapDumpOnOutOfMemoryError was showing up as an undocumented rule, and that seemed a bit surprising.
On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the JAVA_8_DOCUMENTED_XX.
I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.
Progress
- [x] Commit message must refer to an issue
- [x] Change must be properly reviewed (1 review required, with at least 1 Committer)
Integration blocker
⚠️ Title mismatch between PR and JBS for issue JMC-8396
Issue
- JMC-8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError (Task - P5) ⚠️ Title mismatch between PR and JBS.
Reviewers
- Henrik Dafgård (@Gunde - Reviewer)
- Marcus Hirt (@thegreystone - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/646/head:pull/646
$ git checkout pull/646
Update a local copy of the PR:
$ git checkout pull/646
$ git pull https://git.openjdk.org/jmc.git pull/646/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 646
View PR using the GUI difftool:
$ git pr show -t 646
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/646.diff
Using Webrev
Hi @ivoanjo, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ivoanjo" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ivoanjo This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError
Reviewed-by: hdafgard, hirt
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 9 new commits pushed to the master branch:
- 99b58ba1cddadbcad033a95bab343bc53d218990: 8389: JMC must stop using finalizers
- 73c24dd6cca0a4f167ddbd21da13c03f4d26900d: 8404: Update to Eclipse 2025-06
- f1b63e0aeef0252218db03a88ca69c9d7fe5823a: 5705: Explain metaspace in rule results
- ... and 6 more: https://git.openjdk.org/jmc/compare/612df4b11eb65bd6e1666c6e774dc6c9c7bed60b...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde, @thegreystone) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
Hi @ivoanjo! Just type /covered in a comment to indicate that you are covered by the Datadog OCA.
You'll also need to link this PR to https://bugs.openjdk.org/browse/JMC-8396 by adding 8396: as a prefix to the PR title.
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!
@ivoanjo This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ivoanjo The pull request is being re-evaluated and the inactivity timeout has been reset.
You still need to update the title to 8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError
@ivoanjo Your change (at version b5b46c862a92f14c57eee593e2f3d6647b427d32) is now ready to be sponsored by a Committer.
Going to push as commit dd6fd901e3ee4fdd766a2b4dfe43bcc1388fbf2a.
Since your change was applied there have been 9 commits pushed to the master branch:
- 99b58ba1cddadbcad033a95bab343bc53d218990: 8389: JMC must stop using finalizers
- 73c24dd6cca0a4f167ddbd21da13c03f4d26900d: 8404: Update to Eclipse 2025-06
- f1b63e0aeef0252218db03a88ca69c9d7fe5823a: 5705: Explain metaspace in rule results
- ... and 6 more: https://git.openjdk.org/jmc/compare/612df4b11eb65bd6e1666c6e774dc6c9c7bed60b...master
Your commit was automatically rebased without conflicts.
@thegreystone @ivoanjo Pushed as commit dd6fd901e3ee4fdd766a2b4dfe43bcc1388fbf2a.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.