jmc icon indicating copy to clipboard operation
jmc copied to clipboard

8276: UI tests failing on Windows

Open thegreystone opened this issue 1 year ago • 3 comments

Ignoring failing tests for now.


Progress

  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8276: UI tests failing on Windows (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jmc.git pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/594.diff

Webrev

Link to Webrev Comment

thegreystone avatar Oct 21 '24 23:10 thegreystone

:wave: Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 21 '24 23:10 bridgekeeper[bot]

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276: UI tests failing on Windows

Reviewed-by: aptmac, vpurnam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 21 '24 23:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 21 '24 23:10 mlbridge[bot]

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to https://github.com/openjdk/jmc/pull/588.

Wonder what happened to the other CI actions.

aptmac avatar Oct 24 '24 14:10 aptmac

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588.

Wonder what happened to the other CI actions.

@aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing.

viragpurnam avatar Oct 25 '24 03:10 viragpurnam

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588. Wonder what happened to the other CI actions.

@aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing.

Interesting, thanks for the info. Would you happen to know why they didn't run on this PR then? https://github.com/openjdk/jmc/pull/588

aptmac avatar Oct 25 '24 13:10 aptmac

I think "Martin Skarsaune" has not enabled the workflow run in his forked repo.

viragpurnam avatar Oct 25 '24 14:10 viragpurnam

I think "Martin Skarsaune" has not enabled the workflow run in his forked repo.

That might be it, I'll have to poke around a bit more. His first handful of PRs did all the workflows, but his current actions seem to be stuck on a workflow dependency that is failing for a reason not obvious to me.

aptmac avatar Oct 25 '24 14:10 aptmac

Oh ok. I will see the log and try.

viragpurnam avatar Oct 25 '24 14:10 viragpurnam

/integrate

thegreystone avatar Oct 27 '24 18:10 thegreystone

Going to push as commit 9e3bbaa55fafc9ca9a36148076428557ea008f64.

openjdk[bot] avatar Oct 27 '24 18:10 openjdk[bot]

@thegreystone Pushed as commit 9e3bbaa55fafc9ca9a36148076428557ea008f64.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 27 '24 18:10 openjdk[bot]