jmc icon indicating copy to clipboard operation
jmc copied to clipboard

8236: Add support for Jolokia discovery

Open skarsaune opened this issue 1 year ago • 3 comments

Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.

https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery


Progress

  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8236: Add support for Jolokia discovery (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/570/head:pull/570
$ git checkout pull/570

Update a local copy of the PR:
$ git checkout pull/570
$ git pull https://git.openjdk.org/jmc.git pull/570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 570

View PR using the GUI difftool:
$ git pr show -t 570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/570.diff

Webrev

Link to Webrev Comment

skarsaune avatar Jul 02 '24 20:07 skarsaune

:wave: Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 02 '24 20:07 bridgekeeper[bot]

@skarsaune This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8236: Add support for Jolokia discovery

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 37dcf0a3bd7ee5c9b5cc8c507c8554e292a45125: 8240: Upgrade HdrHistogram to 2.2.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Jul 02 '24 20:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 03 '24 12:07 mlbridge[bot]

/integrate

skarsaune avatar Aug 03 '24 12:08 skarsaune

@skarsaune Your change (at version db5128c1f156763a4704227448ea6fff095d103a) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Aug 03 '24 12:08 openjdk[bot]

/sponsor

aptmac avatar Aug 03 '24 17:08 aptmac

Going to push as commit 8a04432f1678a2a9119becd509100417b27b56eb. Since your change was applied there has been 1 commit pushed to the master branch:

  • 37dcf0a3bd7ee5c9b5cc8c507c8554e292a45125: 8240: Upgrade HdrHistogram to 2.2.2

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 03 '24 17:08 openjdk[bot]

@aptmac @skarsaune Pushed as commit 8a04432f1678a2a9119becd509100417b27b56eb.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 03 '24 17:08 openjdk[bot]