jmc
jmc copied to clipboard
7861: Bump Agent build to Java 11 compliance and cleanup POM
The JMC Agent project is set up in a somewhat awkward way at the moment. The maven.compiler.source and maven.compiler.target properties are set to 1.8 but we enforce a JDK 11 during the build and also have a test case that implicitly uses/tests JDK11 features. Maybe it is time now to bump the agent to Java 11 compliance?
Furthermore, the POM file could be cleaned up and a few maven plugins that are used could be bumped to more recent versions.
Progress
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- JMC-7861: Bump Agent build to Java 11 compliance and cleanup POM
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/415/head:pull/415
$ git checkout pull/415
Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.org/jmc pull/415/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 415
View PR using the GUI difftool:
$ git pr show -t 415
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/415.diff
:wave: Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@RealCLanger This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
7861: Bump Agent build to Java 11 compliance and cleanup POM
Reviewed-by: hirt
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Thanks for the review. I merged master and deleted the .gitignored org.eclipse.jdt.core.prefs file. When checks pass I will integrate.
/integrate
Going to push as commit bd35870e44a7260bb017826d97ac8cfc03b0c111.
@RealCLanger Pushed as commit bd35870e44a7260bb017826d97ac8cfc03b0c111.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.