jmc
jmc copied to clipboard
7806: Add an export option for Stacktraces in collapsed format
Add a new context menu when clicking on stacktrace view to export selected stacktraces as collapsed format. With this format it's easy to manipulate/filter stacktraces as text file and generate a flamegraph with the perl script from the flamegraph repository (https://github.com/brendangregg/FlameGraph)
The generated content is copied into the clipboard.
Progress
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- JMC-7806: Add an export option for Stacktraces in collapsed format
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/409/head:pull/409
$ git checkout pull/409
Update a local copy of the PR:
$ git checkout pull/409
$ git pull https://git.openjdk.org/jmc pull/409/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 409
View PR using the GUI difftool:
$ git pr show -t 409
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/409.diff
:wave: Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
yes I need to take into account attribute selected for the export as well
@jpbempel this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout 7806-export-collapsed
git fetch https://git.openjdk.org/jmc.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
Hi @jpbempel! Is this something you would like to get into JMC 9?
Hi @jpbempel! Is this something you would like to get into JMC 9?
Yes! Sorry I am ashamed I let this PR in that while there was really almost nothing left to finish it. Now should be good, you can select the attribute you want to aggregate on before exporting into collapsed format
@jpbempel This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
7806: Add an export option for Stacktraces in collapsed format
Reviewed-by: hirt
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
Hm. I can't set labels for some reason. Can you set the hacktoberfest-accepted label on this PR @jpbempel?
/label add hacktoberfest-accepted
@jpbempel
The label hacktoberfest-accepted is not a valid label.
These labels are valid:
Can't also, this PR is too old :)
/integrate
Going to push as commit b0d11227eff832f5c25ead7d3512f0e34efb8446.
@jpbempel Pushed as commit b0d11227eff832f5c25ead7d3512f0e34efb8446.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
Can't also, this PR is too old :)
Ah. Of course. :)