jmc
jmc copied to clipboard
7538: Check in launcher for JVMKeepAlive
Helpful for new developers.
Progress
- [x] Commit message must refer to an issue
- [x] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- JMC-7538: Check in launcher for JVMKeepAlive
Reviewers
- Alex Macdonald (@aptmac - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/368/head:pull/368
$ git checkout pull/368
Update a local copy of the PR:
$ git checkout pull/368
$ git pull https://git.openjdk.org/jmc pull/368/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 368
View PR using the GUI difftool:
$ git pr show -t 368
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/368.diff
:wave: Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Please add a remark to the devguide on when and how to use it.
Good point. Will add some detail to the devguide.
@thegreystone This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
7538: Check in launcher for JVMKeepAlive
Reviewed-by: aptmac
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 61 new commits pushed to the master branch:
- 095d0687156be8eb3c0cfd7738ea44de6a2b0c55: 7922: Issue using attribute selections in the stack trace view
- 33c4872dd4f4fa2816d99533ac187ee78b117eb7: 7923: Cleanup warnings in core
- a359db89a72abc888a1f8721d1c81c3e781bd003: 7921: Create 8.3 release notes
- e3f4c5bde20730a4e1aecffe263ac185463cd444: 7350: [Accessibility, JAWS] [Misc] Deadlinks in Help Page
- b1494d2cd81a5225e8bd79a55c507ef577476c38: 7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks
- 1696e03a1fddb9cc68d32bf21a281ef24366e552: 7902: UseCompressedOopsRule has flipped comparison
- 9d99d8819e020b98f11ae6a8d2950d8fbed00382: 7910: Fix spotless finding after JMC-7903
- 7cd2f3e730480c833930e36951f8658b4addead4: 7903: FastAccessNumberMap is slow for sparse values
- e6778b191878c68d7c72af93a1a99ee49e0e7caa: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11
- 359f6abe17d81131e6091fa5596d6f45f56613d7: 7870: JMC 8.3.0 Update Site Pages require changes
- ... and 51 more: https://git.openjdk.org/jmc/compare/3f9b42d88900ba49ce305ac975dfe602f281b815...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
/integrate
Going to push as commit ad2171da7dc31fc1e0aab091f2fb6c5ff6062c13.
Since your change was applied there have been 67 commits pushed to the master branch:
- 53991b1167ed02e8b8d8eea55f8037799815c373: 7941: Fixes for Graphview and Flameview projects
- b5f34909964bf387e6edb65aa30f1e082c789d16: 7940: Fix manifest making the Eclipse IDE unhappy
- 0e8e2004c2c9452a03f762796fd70dc410ed9d59: 7939: Cleanup of JDK dependencies in JMC tycho build
- da85800b87382d1f5aeb28c6feca2e7acf00d9cc: 7935: Upgrade the trunk to 9
- 3a0af3723a7389f1c7c8c1f0e8d52dbb83cfb830: 7933: Avoid volatile writes for default field values
- 65bd6b8ee771c9e192cc4f7b260c843684fcd654: 7930: Upgrade to Eclipse 2022-09
- 095d0687156be8eb3c0cfd7738ea44de6a2b0c55: 7922: Issue using attribute selections in the stack trace view
- 33c4872dd4f4fa2816d99533ac187ee78b117eb7: 7923: Cleanup warnings in core
- a359db89a72abc888a1f8721d1c81c3e781bd003: 7921: Create 8.3 release notes
- e3f4c5bde20730a4e1aecffe263ac185463cd444: 7350: [Accessibility, JAWS] [Misc] Deadlinks in Help Page
- ... and 57 more: https://git.openjdk.org/jmc/compare/3f9b42d88900ba49ce305ac975dfe602f281b815...master
Your commit was automatically rebased without conflicts.
@thegreystone Pushed as commit ad2171da7dc31fc1e0aab091f2fb6c5ff6062c13.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.