8293883: Add tests/.classpath (Eclipse)

[andy-goryachev-oracle]

trafficstars

Adding a tests/.classpath file to include tests/manual/controls source folder so Eclipse could see/execute manual tests there.

Also, I would rather move the sources there to a specific package (test.manual ?) instead of a default package. Any objections? edit: won't be done as a part of this PR.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8293883: Add tests/.classpath (Eclipse)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/901/head:pull/901
$ git checkout pull/901

Update a local copy of the PR:
$ git checkout pull/901
$ git pull https://git.openjdk.org/jfx pull/901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 901

View PR using the GUI difftool:
$ git pr show -t 901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/901.diff

[bridgekeeper[bot]]

:wave: Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (9949c68b)
• 00: Full (06877a4b)

[kevinrushforth]

Also, I would rather move the sources there to a specific package (test.manual ?) instead of a default package. Any objections?

That should probably be done via a separate cleanup bug, since it is outside the scope of this IDE-only fix. It would make sense to at least look at all of the manual tests (since they all exist in the unnamed package), even if you want to limit the scope of the follow-on bug to the manual controls tests.

[andy-goryachev-oracle]

@nlisker : could you please review this small change, I wanted to publish a demo/manual test for the constrained resize policy in JDK-8293119 to the mailing list? thank you in advance! -andy

[nlisker]

I was actually reviewing it just now.

Same as with apps, this is not the way the tests should be ordered. While it allows to run them from Eclipse, the way the tests are currently divided means that they should be (sub-) projects. We will need a follow-up on this.

@kevinrushforth Are you planning on continuing the cleanup of apps and tests soon? If so, we should wait for it with the Eclipse changes.

[andy-goryachev-oracle]

There are sources under tests/performance and tests/manual that should also be included in the classpath.

I would like to limit the scope of this PR.

The problem is that one thing leads to another - and the fact that all these manual tests are using the default package instead of their own individual packages might lead to issues and/or require more time and attention.

[nlisker]

The default package is a pre-existing bad practice, but doesn't pose an issue, I tried it myself. It makes little sense to add just one source folder while neglecting all the others. If we are editing this classpath to make the tests runnable (even if with the incorrect configuration), then we should make the tests runnable.

[andy-goryachev-oracle]

Added more dirs under manual/ and performance/ - had to skip certain directories that looked like projects in their own right, or that required additional dependencies.

[openjdk[bot]]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293883: Add tests/.classpath (Eclipse)

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 82db6cc342e7de4391f14c70877e77b0e52fbfff: 8289541: Update ICU4C to 71.1
• 7c6a54d41945a21d2a4f0eceae56b5ba3df9f39f: 8293839: Documentation memory consistency effects of runLater
• a27840e8fd7e79b1692488e4de7f6f5fdb930cf4: 8293368: GitHub Workflows security hardening
• 5e4552db7389d93829e6ecfc61936ccad75c56c2: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy
• cef583eef41aff3db55542d5e90423eec5601f41: 8293214: Add support for Linux/LoongArch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[andy-goryachev-oracle]

/integrate

[openjdk[bot]]

@andy-goryachev-oracle Your change (at version 9949c68b80703358b3594efdaec12fe59c9c355a) is now ready to be sponsored by a Committer.

[nlisker]

/sponsor

[openjdk[bot]]

Going to push as commit 03569b719b9d838d643dc4514971b06617275e86. Since your change was applied there have been 5 commits pushed to the master branch:

• 82db6cc342e7de4391f14c70877e77b0e52fbfff: 8289541: Update ICU4C to 71.1
• 7c6a54d41945a21d2a4f0eceae56b5ba3df9f39f: 8293839: Documentation memory consistency effects of runLater
• a27840e8fd7e79b1692488e4de7f6f5fdb930cf4: 8293368: GitHub Workflows security hardening
• 5e4552db7389d93829e6ecfc61936ccad75c56c2: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy
• cef583eef41aff3db55542d5e90423eec5601f41: 8293214: Add support for Linux/LoongArch64

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@nlisker @andy-goryachev-oracle Pushed as commit 03569b719b9d838d643dc4514971b06617275e86.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.