8290274: DRT 27 tests fail due to xml not well formed error on window

[jaybhaskar]

Issue: xml not well-formed error occurs at XML document parser. Issue: doEnd() call not needed for JAVA platform, as it is making XMLDocumentParserLibxml2 xml not well-formed error.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8290274: DRT 27 tests fail due to xml not well formed error on window

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/866/head:pull/866
$ git checkout pull/866

Update a local copy of the PR:
$ git checkout pull/866
$ git pull https://git.openjdk.org/jfx pull/866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 866

View PR using the GUI difftool:
$ git pr show -t 866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/866.diff

[bridgekeeper[bot]]

:wave: Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 00: Full (ad79e0ff)

[kevinrushforth]

Can you say why the doEnd call is not needed for the Java platform? Have you verified that there is no adverse effect to skipping it?

/reviewers 2

[openjdk[bot]]

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[jaybhaskar]

According to comments mention in the source code: void XMLDocumentParser::end() { // XMLDocumentParserLibxml2 will do bad things to the document if doEnd() is called. // I don't believe XMLDocumentParserQt needs doEnd called in the fragment case.

The doEnd() call not needed for JAVA Platform also, as it is affecting libxml2 parser to generate xml not well formed error.

I have tested it , it fixes 27 test cases with no side effects for other drt tests.

[bridgekeeper[bot]]

@jaybhaskar This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@jaybhaskar This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.