8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

[jperedadnr]

This PR fixes an issue when there is a DialogPane that has no header and no graphic is set, by adding the graphic-container styleclass only when there is a non-null graphic applied, preventing the padding that otherwise the graphic container will keep.

Two tests have been added, to verify that the padding is 0 when there is no graphic (this test fails without this PR) and to verify that the padding is correct when there is a graphic to the left of the content area.

As part of this PR or as possible follow-up, it could be also discussed that the right/bottom padding of the graphic container shouldn't be 0 when there is no header and the graphic is laid out to the left of the content area.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/859/head:pull/859
$ git checkout pull/859

Update a local copy of the PR:
$ git checkout pull/859
$ git pull https://git.openjdk.org/jfx pull/859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 859

View PR using the GUI difftool:
$ git pr show -t 859

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/859.diff

[bridgekeeper[bot]]

:wave: Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 00: Full (5fd2ac66)

[openjdk[bot]]

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 33534cb9e0524e91ed717b22fab667b284c52252: 8291630: Update attribution in webkit.md file
• 38324a70c3054e75cb22865e7ffcc5375b62939d: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1
• b4d86bdffc2dd89e3473884b4079092e7e2843d1: 8218826: TableRowSkinBase: horizontal layout broken if row has padding
• 4c1f4c20b99dfc8c8016c305983dfea5e1b9d6f2: Merge
• dd30402a5c22daf79b88dd35b42f32d0a0e28867: 8291589: Update copyright header for files modified in 2022
• 779365f1af8dc837d7b6d292de5bd8dcd8947290: Merge
• 5febacae1bf6776a31e151ef223739576dab67e6: 8291502: Mouse or touch presses on a non-focusable region don't clear the focusVisible flag of the current focus owner
• 8fa89199e2d07763a3aaab3f3a7904c73457d4a0: 8291588: Update boot JDK to 18.0.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aghaisas]

As part of this PR or as possible follow-up, it could be also discussed that the right/bottom padding of the graphic container shouldn't be 0 when there is no header and the graphic is laid out to the left of the content area.

We can discuss this in a separate JBS issue.

[jperedadnr]

/integrate

[openjdk[bot]]

Going to push as commit bee2dfb848c908c62764a1fa9c071d2cfcf9c1f4. Since your change was applied there have been 14 commits pushed to the master branch:

• d4ff45af9fbde29f96d80681c7fc3af3ec580d1a: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
• 88159811239b76399b8f90c6c648293b4a06528c: 8271395: Crash during printing when disposing textures
• cedc17cc26bb0ad3e2d0693bd174f118ad5f0b82: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant
• 5c47295cf7ff9404b3bddaa2c30772fa2eff461c: 8290473: update Eclipse .classpath in apps, buildSrc
• 2618bf8aeef3c9d9d923576e8a610f5e9b2123f1: 8181084: JavaFX show big icons in system menu on macOS with Retina display
• eaddb0fbeeb99900636f9704758f6c004860ff9a: 8291908: VirtualFlow creates unneeded empty cells
• 33534cb9e0524e91ed717b22fab667b284c52252: 8291630: Update attribution in webkit.md file
• 38324a70c3054e75cb22865e7ffcc5375b62939d: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1
• b4d86bdffc2dd89e3473884b4079092e7e2843d1: 8218826: TableRowSkinBase: horizontal layout broken if row has padding
• 4c1f4c20b99dfc8c8016c305983dfea5e1b9d6f2: Merge
• ... and 4 more: https://git.openjdk.org/jfx/compare/08ec9c8781a57b49a13a2b7febbe33172ebc1a5a...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@jperedadnr Pushed as commit bee2dfb848c908c62764a1fa9c071d2cfcf9c1f4.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jperedadnr]

@aghaisas I've just filed https://bugs.openjdk.org/browse/JDK-8292740 to track the follow-up issue.