jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8290841: Notify menu event after a long press gesture on Android is not dispatched

Open jperedadnr opened this issue 3 years ago • 4 comments
trafficstars

This PR allows dispatching a menu event on Android to trigger a ContextMenuEvent.

It is somehow a follow-up of JDK-8245575, where the same was added for iOS.

While no test can be provided, the current changes have been tested, building and deploying on Android.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8290841: Notify menu event after a long press gesture on Android is not dispatched

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/843/head:pull/843
$ git checkout pull/843

Update a local copy of the PR:
$ git checkout pull/843
$ git pull https://git.openjdk.org/jfx pull/843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 843

View PR using the GUI difftool:
$ git pr show -t 843

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/843.diff

jperedadnr avatar Jul 21 '22 23:07 jperedadnr

:wave: Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 21 '22 23:07 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Jul 21 '22 23:07 mlbridge[bot]

Since this is all Android-only code, perhaps @johanvos can review.

kevinrushforth avatar Jul 22 '22 16:07 kevinrushforth

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290841: Notify menu event after a long press gesture on Android is not dispatched

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 075cc80b57095729fb43c17195f6b17322248748: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals()
  • 9f636da27576b69f797d923599bd4ae4b4d37be8: Merge
  • 6da05c2c7ed8f3911a43f51cbce2a5988a011c7d: 8290348: TreeTableView jumping to top

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 26 '22 08:07 openjdk[bot]

/integrate

jperedadnr avatar Aug 30 '22 09:08 jperedadnr

Going to push as commit f71984938c686e52d61fd9c8470df4b453a253b6. Since your change was applied there have been 35 commits pushed to the master branch:

  • ae9928bc4002122a9fb70e9d49ffe9be0cff1a11: 8287604: Update MarlinFX to 0.9.4.6
  • da580ba4a7e743e2a49f5a2c7f3b40fa01a4438a: 8292609: Cherry-pick WebKit 614.1 stabilization fixes
  • 996eb84b9df484fc78527ded311e7aa06aec56da: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char
  • f95f09f5af561e3a6f3804a4f54aff83e9d2bb0b: 8289542: Update JPEG Image Decoding Software to 9e
  • 6d6726c3d69379559c4d66681726adc4e794899c: Merge
  • 8b96776510908c14a860680ad99404c339faa48f: 8286678: Fix mistakes in FX API docs
  • 5c00783352940b08f6254d2250524ef804984267: 8291906: Bindings.createXxxBinding inherit incorrect method docs
  • 7cb8d679dc2aa96b7c9a2bd60983ab74aa275967: 8235491: Tree/TableView: implementation of isSelected(int) violates contract
  • dee34b42d3443466d81fc4e2a9a2994338b680c0: 8292391: Add support for optional signing of native libraries
  • b951503134bdbc607cfa7a5ff05937f70a1a13dd: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
  • ... and 25 more: https://git.openjdk.org/jfx/compare/54e689ce639ee182113dab610d9ed82890493898...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 30 '22 09:08 openjdk[bot]

@jperedadnr Pushed as commit f71984938c686e52d61fd9c8470df4b453a253b6.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 30 '22 09:08 openjdk[bot]