jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8090522: Allow support for disabling stage iconification (minimization)

Open xardif opened this issue 3 years ago • 6 comments

Stage minimalizing (iconified state) cannot be disabled for the user. The same for Stage closable state. PR adds these features without breaking backward compatibility.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (3 reviews required, with at least 1 reviewer, 2 authors)
  • [ ] Change requires a CSR request to be approved

Issue

  • JDK-8090522: Allow support for disabling stage iconification (minimization)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/798/head:pull/798
$ git checkout pull/798

Update a local copy of the PR:
$ git checkout pull/798
$ git pull https://git.openjdk.java.net/jfx pull/798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 798

View PR using the GUI difftool:
$ git pr show -t 798

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/798.diff

xardif avatar May 19 '22 12:05 xardif

:wave: Welcome back xardif! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 19 '22 12:05 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar May 19 '22 12:05 mlbridge[bot]

@xardif It is premature to review this PR. Please read the section on New features / API additions in the CONTRIBUTING guide for necessary steps, which involves discussing any new feature on the openjfx-dev mailing list to see if there is general support for the idea.

/reviewers 3 /csr

kevinrushforth avatar May 19 '22 13:05 kevinrushforth

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 3 (with 1 of role reviewers, 2 of role authors).

openjdk[bot] avatar May 19 '22 13:05 openjdk[bot]

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request. @xardif please create a CSR request for issue JDK-8090522. This pull request cannot be integrated until the CSR request is approved.

openjdk[bot] avatar May 19 '22 13:05 openjdk[bot]

Marking this as "Draft" since it is not ready for review.

kevinrushforth avatar May 19 '22 13:05 kevinrushforth

@xardif This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 31 '23 23:03 bridgekeeper[bot]

@xardif This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 27 '23 02:05 bridgekeeper[bot]